From 08b51514912dd594a97d2a9f14e242c551b72049 Mon Sep 17 00:00:00 2001 From: Saqib Khan Date: Tue, 29 Aug 2017 10:48:29 -0500 Subject: PNOR: Add logic to handle the case where ubi volume creation failure - Combine the service files that creates the UBI volumes - Add "OnFailure" to service files that creates UBI volumes in order to clean up any ubi voumes or mount points that were created during the activation. - Part of the change required for openbmc/openbmc#1616. Change-Id: Ibe316c810e797b256c141c5ea6583970da5e57b8 Signed-off-by: Saqib Khan --- .../recipes-phosphor/flash/openpower-software-manager.bb | 1 - .../obmc-flash-bios-squashfsmount@.service | 10 ---------- .../obmc-flash-bios-ubimount@.service | 4 +++- 3 files changed, 3 insertions(+), 12 deletions(-) delete mode 100644 meta-openbmc-machines/meta-openpower/common/recipes-phosphor/flash/openpower-software-manager/obmc-flash-bios-squashfsmount@.service (limited to 'meta-openbmc-machines/meta-openpower/common/recipes-phosphor/flash') diff --git a/meta-openbmc-machines/meta-openpower/common/recipes-phosphor/flash/openpower-software-manager.bb b/meta-openbmc-machines/meta-openpower/common/recipes-phosphor/flash/openpower-software-manager.bb index 04cc0dc21..38bc42486 100644 --- a/meta-openbmc-machines/meta-openpower/common/recipes-phosphor/flash/openpower-software-manager.bb +++ b/meta-openbmc-machines/meta-openpower/common/recipes-phosphor/flash/openpower-software-manager.bb @@ -49,7 +49,6 @@ SYSTEMD_SERVICE_${PN} += " \ obmc-flash-bios-ubiumount-ro@.service \ obmc-flash-bios-ubiumount-rw@.service \ obmc-flash-bios-ubipatch.service \ - obmc-flash-bios-squashfsmount@.service \ obmc-flash-bios-ubiremount.service \ obmc-flash-bios-updatesymlinks.service \ " diff --git a/meta-openbmc-machines/meta-openpower/common/recipes-phosphor/flash/openpower-software-manager/obmc-flash-bios-squashfsmount@.service b/meta-openbmc-machines/meta-openpower/common/recipes-phosphor/flash/openpower-software-manager/obmc-flash-bios-squashfsmount@.service deleted file mode 100644 index 96c1eb624..000000000 --- a/meta-openbmc-machines/meta-openpower/common/recipes-phosphor/flash/openpower-software-manager/obmc-flash-bios-squashfsmount@.service +++ /dev/null @@ -1,10 +0,0 @@ -[Unit] -Description=Mount SquashFS image pnor-ro-%I -Requires=obmc-flash-bios-ubiattach.service -After=obmc-flash-bios-ubiattach.service - -[Service] -Type=oneshot -RemainAfterExit=no -ExecStart=/usr/bin/env obmc-flash-bios squashfsmount pnor-ro-%i %i -SyslogIdentifier=obmc-flash-bios diff --git a/meta-openbmc-machines/meta-openpower/common/recipes-phosphor/flash/openpower-software-manager/obmc-flash-bios-ubimount@.service b/meta-openbmc-machines/meta-openpower/common/recipes-phosphor/flash/openpower-software-manager/obmc-flash-bios-ubimount@.service index b4bd2d733..d03041dad 100644 --- a/meta-openbmc-machines/meta-openpower/common/recipes-phosphor/flash/openpower-software-manager/obmc-flash-bios-ubimount@.service +++ b/meta-openbmc-machines/meta-openpower/common/recipes-phosphor/flash/openpower-software-manager/obmc-flash-bios-ubimount@.service @@ -1,11 +1,13 @@ [Unit] -Description=Mount UBIFS volume pnor-prsv and pnor-rw-%I +Description=Mount UBIFS volumes pnor-ro-%I, pnor-rw-%I and pnor-prsv Requires=obmc-flash-bios-ubiattach.service After=obmc-flash-bios-ubiattach.service +OnFailure=obmc-flash-bios-ubiumount-ro@%i.service obmc-flash-bios-ubiumount-rw@%i.service [Service] Type=oneshot RemainAfterExit=no +ExecStart=/usr/bin/env obmc-flash-bios squashfsmount pnor-ro-%i %i ExecStart=/usr/bin/env obmc-flash-bios ubimount pnor-rw-%i ExecStart=/usr/bin/env obmc-flash-bios ubimount pnor-prsv SyslogIdentifier=obmc-flash-bios -- cgit v1.2.3