From 805ae6679f49d0d7a3a6448af97f3cb639b9634f Mon Sep 17 00:00:00 2001 From: Zhikui Ren Date: Tue, 22 Jun 2021 14:49:44 -0700 Subject: [PATCH] CPUSensor: additional debug message Add debug message to capture more information on threshold changes. Example output - DTS threshold changes when Tcontrol was first read Jan 01 00:06:06 intel-obmc cpusensor[461]: Core_16_CPU1: Tcontrol changed from nan to 92 Jan 01 00:06:06 intel-obmc cpusensor[461]: Core_22_CPU1: Tcontrol changed from nan to 92 Jan 01 00:06:06 intel-obmc cpusensor[461]: Core_24_CPU1: Tcontrol changed from nan to 92 Jan 01 00:06:06 intel-obmc cpusensor[461]: DTS_CPU1: Tcontrol changed from nan to 92 Jan 01 00:06:06 intel-obmc cpusensor[461]: Threshold: /sys/bus/peci/devices/peci-0/0-30/peci-cputemp.0/hwmon/hwmon12/temp2_max: 92 Jan 01 00:06:06 intel-obmc cpusensor[461]: Threshold: /sys/bus/peci/devices/peci-0/0-30/peci-cputemp.0/hwmon/hwmon12/temp2_crit: 100 Jan 01 00:06:06 intel-obmc cpusensor[461]: DTS_CPU1: new threshold value 92 Jan 01 00:06:06 intel-obmc cpusensor[461]: DTS_CPU1: new threshold value 100 The above message will be logged when BMC reset or host resets. Signed-off-by: Zhikui Ren --- src/CPUSensor.cpp | 5 +++++ src/Thresholds.cpp | 7 ++----- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/CPUSensor.cpp b/src/CPUSensor.cpp index fefd89a..de33f9b 100644 --- a/src/CPUSensor.cpp +++ b/src/CPUSensor.cpp @@ -315,6 +315,7 @@ void CPUSensor::handleResponse(const boost::system::error_code& err) : std::numeric_limits::quiet_NaN(); if (gTcontrol != privTcontrol) { + std::cout << name << ": Tcontrol changed from " << privTcontrol << " to " << gTcontrol << "\n"; privTcontrol = gTcontrol; if (!thresholds.empty()) @@ -333,6 +334,10 @@ void CPUSensor::handleResponse(const boost::system::error_code& err) thresholds::updateThresholds(this); } } + for (auto& threshold : thresholds) + { + std::cout << name << ": new threshold value " << threshold.value << "\n"; + } } else { diff --git a/src/Thresholds.cpp b/src/Thresholds.cpp index 84df7cf..d1e04eb 100644 --- a/src/Thresholds.cpp +++ b/src/Thresholds.cpp @@ -592,11 +592,8 @@ bool parseThresholdsFromAttr( if (auto val = readFile(attrPath, scaleFactor)) { *val += offset; - if (debug) - { - std::cout << "Threshold: " << attrPath << ": " << *val - << "\n"; - } + std::cout << "Threshold: " << attrPath << ": " << *val + << "\n"; thresholdVector.emplace_back(level, direction, *val); } } -- 2.17.1