summaryrefslogtreecommitdiff
path: root/meta-openbmc-mods/meta-common/recipes-phosphor/interfaces/bmcweb/0004-Bmcweb-handle-permission-denied-exception.patch
blob: 0747183490881e59ab3e7cbf516c6467546a39b4 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
From 81f2c022b22ef75990f30e5ba5bfd4ba5bd41754 Mon Sep 17 00:00:00 2001
From: Alicja Rybak <alicja.rybak@intel.com>
Date: Wed, 14 Apr 2021 16:26:59 +0200
Subject: [PATCH] Bmcweb handle permission denied exception

Add handling of permission denied exception (EPERM) that
can be thrown by VirtualMedia service during Mount/Unmount dbus operations.

Tested:
Verified that after mounting/unmounting HTTPS resource twice in a row in legacy mode,
VirtualMedia returns EPERM, which bmcweb handles as 403 status code.

Change-Id: Ibc18d5ec822c5072605b1fc4651389982002798b
Signed-off-by: Alicja Rybak <alicja.rybak@intel.com>
---
 redfish-core/lib/virtual_media.hpp | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/redfish-core/lib/virtual_media.hpp b/redfish-core/lib/virtual_media.hpp
index 365290b..bbdc91b 100644
--- a/redfish-core/lib/virtual_media.hpp
+++ b/redfish-core/lib/virtual_media.hpp
@@ -900,6 +900,10 @@ class VirtualMediaActionInsertMedia : public Node
                             {
                                 messages::resourceInUse(asyncResp->res);
                             }
+                            else if (ec == boost::system::errc::permission_denied)
+                            {
+                                messages::accessDenied(asyncResp->res, "VirtualMedia.Insert");
+                            }
                             else
                             {
                                 messages::internalError(asyncResp->res);
@@ -1092,6 +1096,10 @@ class VirtualMediaActionEjectMedia : public Node
                             {
                                 messages::resourceInUse(asyncResp->res);
                             }
+                            else if (ec == boost::system::errc::permission_denied)
+                            {
+                                messages::accessDenied(asyncResp->res, "VirtualMedia.Eject");
+                            }
                             else
                             {
                                 messages::internalError(asyncResp->res);