From 5a03fdc6a119b65ecf320622ce2809e340749fa9 Mon Sep 17 00:00:00 2001 From: Richard Marian Thomaiyar Date: Tue, 17 Dec 2019 13:45:25 +0530 Subject: Fix: Ignore Timer when in validation unsecure Ignore timer handler, when we are in validation unsecure mode, and reside in validation unsecure mode itself. i.e. Validation unsecure must be persistent and must not be reseted based on a timer, which will get activated when we execute manufacturing command. Tested: 1. Verfied the Get Security mode command, ipmitool raw 0x30 0xB3 and saw no changes in validation unsecure mode after mfg command execution, and after 15 minutes timeout. Change-Id: Ifb338e13bf3f0a923bc488284cced8448043a2e5 Signed-off-by: Richard Marian Thomaiyar --- special-mode-mgr/src/specialmodemgr.cpp | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/special-mode-mgr/src/specialmodemgr.cpp b/special-mode-mgr/src/specialmodemgr.cpp index b685550..132b26e 100644 --- a/special-mode-mgr/src/specialmodemgr.cpp +++ b/special-mode-mgr/src/specialmodemgr.cpp @@ -264,6 +264,13 @@ void SpecialModeMgr::updateTimer(int countInSeconds) "Error in special mode timer"); return; } +#ifdef BMC_VALIDATION_UNSECURE_FEATURE + if (specialMode == secCtrl::SpecialMode::Modes::ValidationUnsecure) + { + // Don't reset, if in ValidationUnsecure mode + return; + } +#endif iface->set_property( strSpecialMode, secCtrl::convertForMessage(secCtrl::SpecialMode::Modes::None)); -- cgit v1.2.3