From b6cdb90744eba8680dc0ac6ba6de31ec84cb500a Mon Sep 17 00:00:00 2001 From: Yong Li Date: Wed, 18 Dec 2019 19:46:50 +0800 Subject: Change the bios version dbus interface to align with bmcweb bmcweb uses the software interface for bios version query in redfish, to align with it, the settings service implements the software interface, this reference needs to be changed too Tested: AC cycle the host, BiosVersion is the correct bios version: https://$BMCIP/redfish/v1/Systems/system Change-Id: I619de9ff1a2356b7da1c59cfa139344cc2114eeb Signed-off-by: Yong Li --- settings/include/defaults.hpp | 7 ------- 1 file changed, 7 deletions(-) diff --git a/settings/include/defaults.hpp b/settings/include/defaults.hpp index 4e7ea39..b640ad2 100644 --- a/settings/include/defaults.hpp +++ b/settings/include/defaults.hpp @@ -174,13 +174,6 @@ inline void loadSettings(sdbusplus::asio::object_server &objectServer, setting->addProperty("UUID", "00000000-0000-0000-0000-000000000000"); - // TODO needs to remove the below BiosId after the refernce in ipmi oem is - // change to Version property - setting = &settings.emplace_back(objectServer, "/xyz/openbmc_project/bios", - "xyz.openbmc_project.Inventory.Item.Bios"); - - setting->addProperty("BiosId", "NA"); - setting = &settings.emplace_back(objectServer, "/xyz/openbmc_project/software/bios", "xyz.openbmc_project.Software.Version"); -- cgit v1.2.3