diff options
author | Ed Tanous <edtanous@google.com> | 2023-06-30 19:57:26 +0300 |
---|---|---|
committer | Ed Tanous <ed@tanous.net> | 2023-07-11 00:03:22 +0300 |
commit | 0f83707d6f05640eeff012500ebe66a1b8020df5 (patch) | |
tree | 17f04867d57dbf0c64c2e70f659bc55ab6a86e5b | |
parent | d5736ef260c5534fb2fe2ee895d62e91bc9319c3 (diff) | |
download | bmcweb-0f83707d6f05640eeff012500ebe66a1b8020df5.tar.xz |
Implement data pointer clang-tidy check
readability-container-data-pointer flags one error in our codebase, but
can definitely find issues in patchsets. Fix the one error (that came
from crow), and enable the check.
Change-Id: I3045ec9a58d80300c90921dda1a2fe3859ffed7b
Signed-off-by: Ed Tanous <edtanous@google.com>
-rw-r--r-- | .clang-tidy | 1 | ||||
-rw-r--r-- | http/http_server.hpp | 2 |
2 files changed, 2 insertions, 1 deletions
diff --git a/.clang-tidy b/.clang-tidy index 32f7f75243..308c3f9be6 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -280,6 +280,7 @@ performance-unnecessary-value-param, readability-avoid-const-params-in-decls, readability-braces-around-statements, readability-const-return-type, +readability-container-data-pointer, readability-container-size-empty, readability-convert-member-functions-to-static, readability-delete-null-pointer, diff --git a/http/http_server.hpp b/http/http_server.hpp index 258193aee3..91de8db37d 100644 --- a/http/http_server.hpp +++ b/http/http_server.hpp @@ -67,7 +67,7 @@ class Server gmtime_r(&lastTimeT, &myTm); dateStr.resize(100); - size_t dateStrSz = strftime(&dateStr[0], 99, + size_t dateStrSz = strftime(dateStr.data(), dateStr.size() - 1, "%a, %d %b %Y %H:%M:%S GMT", &myTm); dateStr.resize(dateStrSz); } |