summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEd Tanous <edtanous@google.com>2023-04-06 20:07:05 +0300
committerCarson Labrado <clabrado@google.com>2023-04-17 22:11:36 +0300
commit30806a2b2696124771dc72be3f2712b7a39b9d64 (patch)
tree44ede6244941d46cea70e283384463b36749e9aa
parent4efe3e0c02ed5d955175fd863a575e2709a6e461 (diff)
downloadbmcweb-30806a2b2696124771dc72be3f2712b7a39b9d64.tar.xz
Fix clang-tidy issue in aggregation
clang-tidy flags the following error, which is correct. ``` ../redfish-core/include/query.hpp:145:26: error: static member accessed through instance [readability-static-accessed-through-instance,-warnings-as-errors] needToCallHandlers = RedfishAggregator::getInstance().beginAggregation( ``` Tested (Carson): Verified that queries to top level collections as well as aggregated resources still return as expected. Signed-off-by: Ed Tanous <edtanous@google.com> Change-Id: I440fb29d2e0b3da52bfd564676d33b72f69f2fbc Signed-off-by: Carson Labrado <clabrado@google.com>
-rw-r--r--redfish-core/include/query.hpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/redfish-core/include/query.hpp b/redfish-core/include/query.hpp
index 1fb0bd87d1..10a337b96b 100644
--- a/redfish-core/include/query.hpp
+++ b/redfish-core/include/query.hpp
@@ -148,8 +148,8 @@ inline bool handleIfMatch(crow::App& app, const crow::Request& req,
bool needToCallHandlers = true;
#ifdef BMCWEB_ENABLE_REDFISH_AGGREGATION
- needToCallHandlers = RedfishAggregator::getInstance().beginAggregation(
- req, asyncResp) == Result::LocalHandle;
+ needToCallHandlers = RedfishAggregator::beginAggregation(req, asyncResp) ==
+ Result::LocalHandle;
// If the request should be forwarded to a satellite BMC then we don't want
// to write anything to the asyncResp since it will get overwritten later.