diff options
| author | Ed Tanous <edtanous@google.com> | 2022-05-17 01:59:35 +0300 |
|---|---|---|
| committer | Ed Tanous <ed@tanous.net> | 2022-05-25 07:58:55 +0300 |
| commit | b1e8a8e38db7cf36f8d93071d9aff1989d447d43 (patch) | |
| tree | 9b2f365b3291ae384f8b77e6e78eecaf07f7b564 | |
| parent | 8868776ed92fa700a47acec609093dbf04221444 (diff) | |
| download | bmcweb-b1e8a8e38db7cf36f8d93071d9aff1989d447d43.tar.xz | |
Remove messages::operationFailed from processor
A file write error being returned from dbus is by definition, an
internal error that the user can do nothing about, so it should be
returning internal error (ie 500) to the user, rather than
OperationFailed. OperationFailed refers to aggregation proxy use cases,
so its use here, while an understandable mistake, because dbus is
arguably a "proxy", is incorrect, and should be fixed.
Tested: Code compiles, no good way to test error cases. Inspection
only.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I01aae6bcf377d019ff6e868309f87959281a2156
| -rw-r--r-- | redfish-core/lib/processor.hpp | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/redfish-core/lib/processor.hpp b/redfish-core/lib/processor.hpp index e0346debc6..1b7fa9ac5f 100644 --- a/redfish-core/lib/processor.hpp +++ b/redfish-core/lib/processor.hpp @@ -977,13 +977,6 @@ inline void // in a different system state. messages::resourceInStandby(resp->res); } - else if (strcmp(dbusError->name, - "xyz.openbmc_project.Common.Device.Error.WriteFailure") == - 0) - { - // Service tried to change the config, but it failed. - messages::operationFailed(resp->res); - } else { messages::internalError(resp->res); |