summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorClaire Weinan <cweinan@google.com>2022-08-16 00:20:06 +0300
committerEd Tanous <ed@tanous.net>2022-08-22 19:38:49 +0300
commitdd72e87b0588dcc2e2732cd47e5c9468a6386200 (patch)
treea609037062260176baf678acb3d84ad26d3ba2c1
parentb4d7181a3956cab5a9136e2ffb338e8be2ccd06a (diff)
downloadbmcweb-dd72e87b0588dcc2e2732cd47e5c9468a6386200.tar.xz
Fix function name handleLogServicesCollectionGet
Renamed handleLogServicesCollectionGet() to handleBMCLogServicesCollectionGet() (added "BMC"). handleLogServicesCollectionGet() was a function first introduced in https://gerrit.openbmc.org/c/openbmc/bmcweb/+/53175 but the function name was accidentally made to be too broad. The function only handles outputting the collection of LogServices specifically under /redfish/v1/Managers/bmc/LogServices. No expected client impact. Tested: Redfish Service Validator succeeded on the following URI: /redfish/v1/Managers/bmc/LogServices/ Signed-off-by: Claire Weinan <cweinan@google.com> Change-Id: I4648db2eaa5417c2428b514fdda1dbf82af0b3f0
-rw-r--r--redfish-core/lib/log_services.hpp6
1 files changed, 3 insertions, 3 deletions
diff --git a/redfish-core/lib/log_services.hpp b/redfish-core/lib/log_services.hpp
index ee3ccfc6c4..c3b659e70d 100644
--- a/redfish-core/lib/log_services.hpp
+++ b/redfish-core/lib/log_services.hpp
@@ -2004,7 +2004,7 @@ inline void requestRoutesSystemHostLoggerLogEntry(App& app)
constexpr char const* dumpManagerIface =
"xyz.openbmc_project.Collection.DeleteAll";
-inline void handleLogServicesCollectionGet(
+inline void handleBMCLogServicesCollectionGet(
crow::App& app, const crow::Request& req,
const std::shared_ptr<bmcweb::AsyncResp>& asyncResp)
{
@@ -2039,7 +2039,7 @@ inline void handleLogServicesCollectionGet(
if (ec)
{
BMCWEB_LOG_ERROR
- << "handleLogServicesCollectionGet respHandler got error "
+ << "handleBMCLogServicesCollectionGet respHandler got error "
<< ec;
// Assume that getting an error simply means there are no dump
// LogServices. Return without adding any error response.
@@ -2083,7 +2083,7 @@ inline void requestRoutesBMCLogServiceCollection(App& app)
BMCWEB_ROUTE(app, "/redfish/v1/Managers/bmc/LogServices/")
.privileges(redfish::privileges::getLogServiceCollection)
.methods(boost::beast::http::verb::get)(
- std::bind_front(handleLogServicesCollectionGet, std::ref(app)));
+ std::bind_front(handleBMCLogServicesCollectionGet, std::ref(app)));
}
inline void requestRoutesBMCJournalLogService(App& app)