Turn on ALL perf checks

1st, alphabetize the tidy-list for good housekeeping.

Next, enable all the clang-tidy performance checks, and resolve all the
issues.  most of the issues boil down to:
1. Using std::move on const variables.  This does nothing.
2. Passing big variables (like std::string) by value.
3. Using double quotes on a find call, which constructs an intermediate
string, rather than using the character overload.

Tested
Loaded on system, logged in successfully and pulled down webui-vue.  No
new errors.

Walked the Redfish tree a bit, and observed no new problems.

Ran redfish service validator.  Got no new failures (although there are
a lot of log service deprecation warnings that we should look at).

Signed-off-by: Ed Tanous <ed@tanous.net>
Change-Id: I2238958c4b22c1e554e09a0a1787c744bdbca43e

1 files changed, 0 insertions, 11 deletions

diff --git a/http/http_response.hpp b/http/http_response.hpp
index b521b20331..7b8b5d99a5 100644
--- a/http/http_response.hpp
+++ b/http/http_response.hpp
@@ -37,17 +37,6 @@ struct Response
     Response() : stringResponse(response_type{})
     {}
 
-    Response(Response&& r)
-    {
-        BMCWEB_LOG_DEBUG << "Moving response containers";
-        *this = std::move(r);
-    }
-
-    ~Response()
-    {
-        BMCWEB_LOG_DEBUG << this << " Destroying response";
-    }
-
     Response& operator=(const Response& r) = delete;
 
     Response& operator=(Response&& r) noexcept