diff options
| author | Ed Tanous <edtanous@google.com> | 2023-04-25 01:28:50 +0300 |
|---|---|---|
| committer | Ed Tanous <ed@tanous.net> | 2023-05-16 19:05:33 +0300 |
| commit | ef4c65b741724d724452a3a0efe8dff0d450514a (patch) | |
| tree | 9667bdff1dd9d2dbeac94bc8bd46efd83177512b /http/routing.hpp | |
| parent | a87c4180fd7f2127960fbc4c89c31b7659f0cfb8 (diff) | |
| download | bmcweb-ef4c65b741724d724452a3a0efe8dff0d450514a.tar.xz | |
Boost::urls::format
Boost 1.82 dropped a lovely new toy, boost::urls::format, which is a lot
like our urlFromPieces method, but better in that it makes the resulting
uris more readable, and allows doing things like fragments in a single
line instead of multiple. We should prefer it in some cases.
Tested:
Redfish service validator passes.
Spot checks of URLs work as expected.
Unit tests pass.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Ia7b38f0a95771c862507e7d5b4aa68aa1c98403c
Diffstat (limited to 'http/routing.hpp')
| -rw-r--r-- | http/routing.hpp | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/http/routing.hpp b/http/routing.hpp index 5bf6902e9c..84213b2289 100644 --- a/http/routing.hpp +++ b/http/routing.hpp @@ -16,6 +16,7 @@ #include <boost/beast/ssl/ssl_stream.hpp> #include <boost/container/flat_map.hpp> +#include <boost/url/format.hpp> #include <sdbusplus/unpack_properties.hpp> #include <cerrno> @@ -1105,9 +1106,10 @@ class Router if (req.session->isConfigureSelfOnly) { redfish::messages::passwordChangeRequired( - asyncResp->res, crow::utility::urlFromPieces( - "redfish", "v1", "AccountService", - "Accounts", req.session->username)); + asyncResp->res, + boost::urls::format( + "/redfish/v1/AccountService/Accounts/{}", + req.session->username)); } return false; } |