diff options
| author | Ed Tanous <edtanous@google.com> | 2023-02-16 21:37:01 +0300 |
|---|---|---|
| committer | Ed Tanous <ed@tanous.net> | 2023-02-24 20:21:40 +0300 |
| commit | 5e7e2dc585dc7a7e62d2b648b541e7f50c39ea5d (patch) | |
| tree | ee3993e0fb2dc6e244a5fc31c7e83b26783161ee /http | |
| parent | 26ccae32112679c4653c1e3f8a1203c828bea05c (diff) | |
| download | bmcweb-5e7e2dc585dc7a7e62d2b648b541e7f50c39ea5d.tar.xz | |
Take boost error_code by reference
By convention, we should be following boost here, and passing error_code
by reference, not by value. This makes our code consistent, and removes
the need for a copy in some cases.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Id42ea4a90b6685a84818b87d1506c11256b3b9ae
Diffstat (limited to 'http')
| -rw-r--r-- | http/http_client.hpp | 2 | ||||
| -rw-r--r-- | http/http_server.hpp | 2 | ||||
| -rw-r--r-- | http/routing.hpp | 2 | ||||
| -rw-r--r-- | http/websocket.hpp | 4 |
4 files changed, 5 insertions, 5 deletions
diff --git a/http/http_client.hpp b/http/http_client.hpp index c902e1a66b..fff261fe46 100644 --- a/http/http_client.hpp +++ b/http/http_client.hpp @@ -401,7 +401,7 @@ class ConnectionInfo : public std::enable_shared_from_this<ConnectionInfo> } static void onTimeout(const std::weak_ptr<ConnectionInfo>& weakSelf, - const boost::system::error_code ec) + const boost::system::error_code& ec) { if (ec == boost::asio::error::operation_aborted) { diff --git a/http/http_server.hpp b/http/http_server.hpp index cc4fc2294d..3949a46ab0 100644 --- a/http/http_server.hpp +++ b/http/http_server.hpp @@ -181,7 +181,7 @@ class Server } acceptor->async_accept( boost::beast::get_lowest_layer(connection->socket()), - [this, connection](boost::system::error_code ec) { + [this, connection](const boost::system::error_code& ec) { if (!ec) { boost::asio::post(*this->ioService, diff --git a/http/routing.hpp b/http/routing.hpp index ae63f0504c..736ec38c7a 100644 --- a/http/routing.hpp +++ b/http/routing.hpp @@ -1374,7 +1374,7 @@ class Router crow::connections::systemBus->async_method_call( [req{std::move(req)}, asyncResp, &rule, params]( - const boost::system::error_code ec, + const boost::system::error_code& ec, const dbus::utility::DBusPropertiesMap& userInfoMap) mutable { if (ec) { diff --git a/http/websocket.hpp b/http/websocket.hpp index c36e579ea8..f17ee5e7d0 100644 --- a/http/websocket.hpp +++ b/http/websocket.hpp @@ -138,7 +138,7 @@ class ConnectionImpl : public Connection // Perform the websocket upgrade ws.async_accept(req, [this, self(shared_from_this())]( - boost::system::error_code ec) { + const boost::system::error_code& ec) { if (ec) { BMCWEB_LOG_ERROR << "Error in ws.async_accept " << ec; @@ -180,7 +180,7 @@ class ConnectionImpl : public Connection { ws.async_close( {boost::beast::websocket::close_code::normal, msg}, - [self(shared_from_this())](boost::system::error_code ec) { + [self(shared_from_this())](const boost::system::error_code& ec) { if (ec == boost::asio::error::operation_aborted) { return; |