diff options
| author | Ed Tanous <ed@tanous.net> | 2024-03-28 02:31:46 +0300 |
|---|---|---|
| committer | Ed Tanous <ed@tanous.net> | 2024-04-07 21:09:42 +0300 |
| commit | 8cb2c024c4625e2fe2f0b107a865faffcd4bb770 (patch) | |
| tree | 252d85214747ab3b9ae784b08b0f07ec31ea0c13 /include/async_resolve.hpp | |
| parent | dce4d230c52978fc258ee3bc31117389d9c25388 (diff) | |
| download | bmcweb-8cb2c024c4625e2fe2f0b107a865faffcd4bb770.tar.xz | |
Fix moves/forward
Clang has new checks for std::move/std::forward correctness, which
catches quite a few "wrong" things where we were making copies of
callback handlers.
Unfortunately, the lambda syntax of
callback{std::forward<Callback>(callback)}
in a capture confuses it, so change usages to
callback = std::forward<Callback>(callback)
to be consistent.
Tested: Redfish service validator passes.
Change-Id: I7a111ec00cf78ecb7d5f5b102c786c1c14d74384
Signed-off-by: Ed Tanous <ed@tanous.net>
Diffstat (limited to 'include/async_resolve.hpp')
| -rw-r--r-- | include/async_resolve.hpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/async_resolve.hpp b/include/async_resolve.hpp index 805fbad124..798c3e8964 100644 --- a/include/async_resolve.hpp +++ b/include/async_resolve.hpp @@ -83,7 +83,7 @@ class Resolver uint64_t flag = 0; crow::connections::systemBus->async_method_call( [host{std::string(host)}, portNum, - handler{std::forward<ResolveHandler>(handler)}]( + handler = std::forward<ResolveHandler>(handler)]( const boost::system::error_code& ec, const std::vector< std::tuple<int32_t, int32_t, std::vector<uint8_t>>>& resp, |