diff options
| author | Ed Tanous <ed@tanous.net> | 2024-03-28 02:31:46 +0300 |
|---|---|---|
| committer | Ed Tanous <ed@tanous.net> | 2024-04-07 21:09:42 +0300 |
| commit | 8cb2c024c4625e2fe2f0b107a865faffcd4bb770 (patch) | |
| tree | 252d85214747ab3b9ae784b08b0f07ec31ea0c13 /include/dbus_utility.hpp | |
| parent | dce4d230c52978fc258ee3bc31117389d9c25388 (diff) | |
| download | bmcweb-8cb2c024c4625e2fe2f0b107a865faffcd4bb770.tar.xz | |
Fix moves/forward
Clang has new checks for std::move/std::forward correctness, which
catches quite a few "wrong" things where we were making copies of
callback handlers.
Unfortunately, the lambda syntax of
callback{std::forward<Callback>(callback)}
in a capture confuses it, so change usages to
callback = std::forward<Callback>(callback)
to be consistent.
Tested: Redfish service validator passes.
Change-Id: I7a111ec00cf78ecb7d5f5b102c786c1c14d74384
Signed-off-by: Ed Tanous <ed@tanous.net>
Diffstat (limited to 'include/dbus_utility.hpp')
| -rw-r--r-- | include/dbus_utility.hpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/dbus_utility.hpp b/include/dbus_utility.hpp index 933d733f96..c06ba9eae6 100644 --- a/include/dbus_utility.hpp +++ b/include/dbus_utility.hpp @@ -147,7 +147,7 @@ template <typename Callback> inline void checkDbusPathExists(const std::string& path, Callback&& callback) { crow::connections::systemBus->async_method_call( - [callback{std::forward<Callback>(callback)}]( + [callback = std::forward<Callback>(callback)]( const boost::system::error_code& ec, const dbus::utility::MapperGetObject& objectNames) { callback(!ec && !objectNames.empty()); |