diff options
| author | Ed Tanous <ed@tanous.net> | 2020-10-21 22:33:42 +0300 |
|---|---|---|
| committer | Sunitha Harish <sunharis@in.ibm.com> | 2020-10-23 14:23:01 +0300 |
| commit | dc511aa73001a593a16dbcdaa5d53f320e4c7818 (patch) | |
| tree | b57239d7550273bcd571ffba721345814288feb5 /include/kvm_websocket.hpp | |
| parent | c7d3422c108c6a88bbeffcea3edbb3f59e3992e3 (diff) | |
| download | bmcweb-dc511aa73001a593a16dbcdaa5d53f320e4c7818.tar.xz | |
Timeout is not per-session
fix regression on 5fb91ba400e0482813cf5e1a86fdca17468d0a6a.
Timeout is a global setting, not a per-session setting. This caused
problems with regenerating it, as session restoration doesn't follow the
"best effort" policy we've done before.
This commit:
1. Makes Session::fromJson more robust against extra keys.
2. Disallowed reading in client_id if IBM_Management_console isn't
enabled.
3. Moves timeout to the proper place in the persistent config file.
Resolves https://github.com/openbmc/bmcweb/issues/158
Tested:
Downloaded to bmc, cleared bmcweb_persistent_data.json, then logged in
using webui-vue.
Rebooted BMC.
Reloaded /redfish/v1/SessionService/Sessions/<sessionid> and observed
that all data restored properly. Unclear why, but ClientOriginIPAddress
seems broken, but that seems true prior to this patch.
Data that got returned is included for completeness.
{
"@odata.id": "/redfish/v1/SessionService/Sessions/BKqK5dNfNS",
"@odata.type": "#Session.v1_3_0.Session",
"ClientOriginIPAddress": "",
"Description": "Manager User Session",
"Id": "BKqK5dNfNS",
"Name": "User Session",
"UserName": "root"
}
Signed-off-by: Ed Tanous <ed@tanous.net>
Change-Id: I716431fd4775af63715d07973f723caa8cb34259
Diffstat (limited to 'include/kvm_websocket.hpp')
0 files changed, 0 insertions, 0 deletions