diff options
| author | Ed Tanous <edtanous@google.com> | 2023-05-11 19:51:51 +0300 |
|---|---|---|
| committer | Ed Tanous <ed@tanous.net> | 2023-05-26 00:09:16 +0300 |
| commit | 4b242749b31b16c663fe2e95ad7dbc6a2f3ca973 (patch) | |
| tree | 6d6ceaab871c6f2101e874d7f980cdc3d68530a9 /include/openbmc_dbus_rest.hpp | |
| parent | 283860f5fb0e685d6c5e8c149451f0d1be0b9103 (diff) | |
| download | bmcweb-4b242749b31b16c663fe2e95ad7dbc6a2f3ca973.tar.xz | |
Make all std::regex instances static
Per [1] we really shouldn't be using regex. In the cases we do, it's a
HUUUUUGE performance benefit to be compiling the regex ONCE.
The only downside is a slight increase in memory usage.
[1]: https://github.com/openbmc/bmcweb/issues/176
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I8644b8a07810349fb60bfa0258a13e815912a38e
Diffstat (limited to 'include/openbmc_dbus_rest.hpp')
| -rw-r--r-- | include/openbmc_dbus_rest.hpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/openbmc_dbus_rest.hpp b/include/openbmc_dbus_rest.hpp index 51257642cb..0fbef04921 100644 --- a/include/openbmc_dbus_rest.hpp +++ b/include/openbmc_dbus_rest.hpp @@ -101,7 +101,7 @@ const constexpr char* forbiddenResDesc = inline bool validateFilename(const std::string& filename) { - std::regex validFilename(R"(^[\w\- ]+(\.?[\w\- ]*)$)"); + static std::regex validFilename(R"(^[\w\- ]+(\.?[\w\- ]*)$)"); return std::regex_match(filename, validFilename); } @@ -2562,7 +2562,7 @@ inline void requestRoutes(App& app) // Filename should be in alphanumeric, dot and underscore // Its based on phosphor-debug-collector application // dumpfile format - std::regex dumpFileRegex("[a-zA-Z0-9\\._]+"); + static std::regex dumpFileRegex("[a-zA-Z0-9\\._]+"); if (!std::regex_match(dumpFileName, dumpFileRegex)) { BMCWEB_LOG_ERROR << "Invalid dump filename " << dumpFileName; |