diff options
| author | Ed Tanous <edtanous@google.com> | 2022-06-06 19:57:26 +0300 |
|---|---|---|
| committer | Ed Tanous <ed@tanous.net> | 2022-06-30 21:48:06 +0300 |
| commit | 4e23a444e8503fd03ab40de2844c783e142ebef8 (patch) | |
| tree | f3d9d1fbe5dde9f0d5e1bc23bfb2ac326bf23a4f /include/openbmc_dbus_rest.hpp | |
| parent | 69320d54efe41fa5b0947adab5702d9023cc1ee3 (diff) | |
| download | bmcweb-4e23a444e8503fd03ab40de2844c783e142ebef8.tar.xz | |
Require explicit decorator on one arg constructors
We essentially follow this rule already, not relying on implicit
operators, although there are a number of cases where in theory we
could've implicitly constructed an object.
This commit enables the clang-tidy check.
Tested: Code compiles, passes clang-tidy.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Ia428463313b075c69614fdb326e8c5c094e7adde
Diffstat (limited to 'include/openbmc_dbus_rest.hpp')
| -rw-r--r-- | include/openbmc_dbus_rest.hpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/openbmc_dbus_rest.hpp b/include/openbmc_dbus_rest.hpp index 76410237bc..0e2af700f6 100644 --- a/include/openbmc_dbus_rest.hpp +++ b/include/openbmc_dbus_rest.hpp @@ -436,7 +436,7 @@ inline void getObjectAndEnumerate( // Structure for storing data on an in progress action struct InProgressActionData { - InProgressActionData(crow::Response& resIn) : res(resIn) + explicit InProgressActionData(crow::Response& resIn) : res(resIn) {} ~InProgressActionData() { @@ -1781,7 +1781,7 @@ inline void handleGet(const std::shared_ptr<bmcweb::AsyncResp>& asyncResp, struct AsyncPutRequest { - AsyncPutRequest(const std::shared_ptr<bmcweb::AsyncResp>& resIn) : + explicit AsyncPutRequest(const std::shared_ptr<bmcweb::AsyncResp>& resIn) : asyncResp(resIn) {} ~AsyncPutRequest() |