diff options
| author | AppaRao Puli <apparao.puli@linux.intel.com> | 2018-12-26 17:56:22 +0300 |
|---|---|---|
| committer | Ed Tanous <ed.tanous@intel.com> | 2018-12-27 23:56:59 +0300 |
| commit | 4d72dcc3ba9cad9de18b969c6472a4dde8e908b5 (patch) | |
| tree | 2d1c5ce88997a311166950cd6d8a7db291bc795c /include | |
| parent | 7e51389af31e510d81297189df20c9a6d82d9b25 (diff) | |
| download | bmcweb-4d72dcc3ba9cad9de18b969c6472a4dde8e908b5.tar.xz | |
REST: Fixed issues with rest POST method
Fixes the below issues in rest actions
- Fetching dbus signature from xml arg elements.
- Double iterator increament, while reading array
of strings 'as'.
Test:
Verified rest API's with actions(POST).
Change-Id: I52ca938bae54c882da2f9f445ea0b4e605a5f8c3
Signed-off-by: AppaRao Puli <apparao.puli@linux.intel.com>
Diffstat (limited to 'include')
| -rw-r--r-- | include/openbmc_dbus_rest.hpp | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/include/openbmc_dbus_rest.hpp b/include/openbmc_dbus_rest.hpp index c3908ca08e..fe85d65e94 100644 --- a/include/openbmc_dbus_rest.hpp +++ b/include/openbmc_dbus_rest.hpp @@ -652,8 +652,6 @@ int convertJsonToDbus(sd_bus_message *m, const std::string &arg_type, { return r; } - - it++; } sd_bus_message_close_container(m); } @@ -830,7 +828,6 @@ void findActionOnInterface(std::shared_ptr<InProgressActionData> transaction, argType != nullptr && std::string(argDirection) == "in") { - if (argIt == transaction->arguments.end()) { @@ -850,7 +847,7 @@ void findActionOnInterface(std::shared_ptr<InProgressActionData> transaction, argIt++; } argumentNode = - methodNode->NextSiblingElement("arg"); + argumentNode->NextSiblingElement("arg"); } crow::connections::systemBus->async_send( |