diff options
| author | Ed Tanous <ed@tanous.net> | 2024-04-12 08:21:38 +0300 |
|---|---|---|
| committer | Ed Tanous <ed@tanous.net> | 2024-04-13 18:28:14 +0300 |
| commit | 8e8245db1812bb0ec294a1c9a97c3a65558840ed (patch) | |
| tree | 3c0d049cd5eddb5ff8e7364129dab0aac1278678 /include | |
| parent | 6f056f246d9bcfd611102ee712d4a2935504b448 (diff) | |
| download | bmcweb-8e8245db1812bb0ec294a1c9a97c3a65558840ed.tar.xz | |
Fix nullptr failures for image upload
Several places that call *req.ioService were missing nullptr checks.
Add them, and fix the one case where it might not be filled in.
Tested: With HTTP2 enabled, the following command succeeds.
```
curl -k https://192.168.7.2/redfish/v1/UpdateService/update -F 'UpdateParameters={"Targets":["/redfish/v1/Managers/bmc"]} ;type=application/json' --user "root:0penBmc" -F UpdateFile=@/home/ed/bmcweb/16mb.txt -v -H "Expect:"
```
Change-Id: I81e7944c22f5922d461bf5d231086c7468a16e62
Signed-off-by: Ed Tanous <ed@tanous.net>
Diffstat (limited to 'include')
| -rw-r--r-- | include/image_upload.hpp | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/include/image_upload.hpp b/include/image_upload.hpp index ef615cb3b8..8b3dc107c9 100644 --- a/include/image_upload.hpp +++ b/include/image_upload.hpp @@ -31,6 +31,12 @@ inline void asyncResp->res.result(boost::beast::http::status::service_unavailable); return; } + if (req.ioService == nullptr) + { + asyncResp->res.result( + boost::beast::http::status::internal_server_error); + return; + } // Make this const static so it survives outside this method static boost::asio::steady_timer timeout(*req.ioService, std::chrono::seconds(5)); |