diff options
| author | Nan Zhou <nanzhoumails@gmail.com> | 2022-05-18 00:12:43 +0300 |
|---|---|---|
| committer | Ed Tanous <ed@tanous.net> | 2022-05-19 22:56:00 +0300 |
| commit | 9a5aceac206a550930204f102f1b84d808579407 (patch) | |
| tree | fa0e1a8af6e4175f343bb0d70dafd7d38be15837 /include | |
| parent | 6a409c12ced1ae98773ea018767e386ace2ed742 (diff) | |
| download | bmcweb-9a5aceac206a550930204f102f1b84d808579407.tar.xz | |
memory: move long code blocks in callbacks into separate functions
It is a bit cleaner to have separate functions rather than keep codes in
the callback, as callback normally have deeper indent.
The main reason is that this helps code review of later changes that
make Expand at MemoryCollection efficient.
Tested:
1. Tested on my mock environment,
```
URI: /redfish/v1/Systems/system/Memory/dimm0
{
"@odata.id": "/redfish/v1/Systems/system/Memory/dimm0",
"@odata.type": "#Memory.v1_11_0.Memory",
"AllowedSpeedsMHz": [],
"BaseModuleType": "RDIMM",
"BusWidthBits": 0,
"CapacityMiB": 1024,
"DataWidthBits": 0,
"ErrorCorrection": "NoECC",
"FirmwareRevision": "0",
"Id": "dimm0",
"Name": "DIMM Slot",
"OperatingSpeedMhz": 0,
"RankCount": 0,
"Status": {
"Health": "OK",
"HealthRollup": "OK",
"State": "Enabled"
}
}
```
2. No new Redfish Validator failures on MemoryCollection on real
hardware.
Signed-off-by: Nan Zhou <nanzhoumails@gmail.com>
Change-Id: I7693388049aeffa6ebd285b958e5ca6622e5d3b6
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions