diff options
author | Ed Tanous <edtanous@google.com> | 2022-07-01 01:55:45 +0300 |
---|---|---|
committer | Ed Tanous <ed@tanous.net> | 2022-12-21 20:15:07 +0300 |
commit | f8fe53e7114ab10c9059377541277739ace5c1ff (patch) | |
tree | 368784d5e265e876e05523493cf058c5d24c8240 /include | |
parent | 6dcbb8675d5c5765c3e53354b8f3b339effecd44 (diff) | |
download | bmcweb-f8fe53e7114ab10c9059377541277739ace5c1ff.tar.xz |
Change variable scopes
cppcheck correctly notes that a lot of our variables can be declared at
more specific scopes, and in every case, it seems to be correct.
Tested: Redfish service validator passes. Unit test coverage on others.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Ia4414410d0e8f74a3bd40fdc0e0232450d1a6416
Diffstat (limited to 'include')
-rw-r--r-- | include/dbus_monitor.hpp | 8 | ||||
-rw-r--r-- | include/http_utility.hpp | 3 | ||||
-rw-r--r-- | include/ibm/locks.hpp | 5 | ||||
-rw-r--r-- | include/openbmc_dbus_rest.hpp | 3 |
4 files changed, 6 insertions, 13 deletions
diff --git a/include/dbus_monitor.hpp b/include/dbus_monitor.hpp index 5f409d7d70..0838f0ae6c 100644 --- a/include/dbus_monitor.hpp +++ b/include/dbus_monitor.hpp @@ -167,9 +167,7 @@ inline void requestRoutes(App& app) // PropertiesChanged thisSession.matches.reserve(thisSession.matches.size() + paths->size() * (1U + interfaceCount)); - std::string objectManagerMatchString; - std::string propertiesMatchString; - std::string objectManagerInterfacesMatchString; + // These regexes derived on the rules here: // https://dbus.freedesktop.org/doc/dbus-specification.html#message-protocol-names std::regex validPath("^/([A-Za-z0-9_]+/?)*$"); @@ -192,7 +190,7 @@ inline void requestRoutes(App& app) conn.close(); return; } - propertiesMatchString = + std::string propertiesMatchString = ("type='signal'," "interface='org.freedesktop.DBus.Properties'," "path_namespace='" + @@ -234,7 +232,7 @@ inline void requestRoutes(App& app) onPropertyUpdate, &conn)); } } - objectManagerMatchString = + std::string objectManagerMatchString = ("type='signal'," "interface='org.freedesktop.DBus.ObjectManager'," "path_namespace='" + diff --git a/include/http_utility.hpp b/include/http_utility.hpp index cd1be3e2b1..e1a8e2a9ea 100644 --- a/include/http_utility.hpp +++ b/include/http_utility.hpp @@ -44,11 +44,10 @@ constexpr std::array<ContentTypePair, 4> contentTypes{{ inline ContentType getPreferedContentType(std::string_view header, std::span<ContentType> preferedOrder) { - size_t index = 0; size_t lastIndex = 0; while (lastIndex < header.size() + 1) { - index = header.find(',', lastIndex); + size_t index = header.find(',', lastIndex); if (index == std::string_view::npos) { index = header.size(); diff --git a/include/ibm/locks.hpp b/include/ibm/locks.hpp index e713f97b8e..e3abb46e92 100644 --- a/include/ibm/locks.hpp +++ b/include/ibm/locks.hpp @@ -431,12 +431,9 @@ inline bool Lock::isValidLockRequest(const LockRequest& refLockRecord) inline Rc Lock::isConflictWithTable(const LockRequests& refLockRequestStructure) { - - uint32_t thisTransactionId = 0; - if (lockTable.empty()) { - thisTransactionId = generateTransactionId(); + uint32_t thisTransactionId = generateTransactionId(); BMCWEB_LOG_DEBUG << thisTransactionId; // Lock table is empty, so we are safe to add the lockrecords // as there will be no conflict diff --git a/include/openbmc_dbus_rest.hpp b/include/openbmc_dbus_rest.hpp index 95503d706e..0e3e070ccd 100644 --- a/include/openbmc_dbus_rest.hpp +++ b/include/openbmc_dbus_rest.hpp @@ -432,7 +432,6 @@ inline void getObjectAndEnumerate( { for (const auto& connection : object.second) { - std::string& objectManagerPath = connections[connection.first]; for (const auto& interface : connection.second) { BMCWEB_LOG_DEBUG << connection.first << " has interface " @@ -441,7 +440,7 @@ inline void getObjectAndEnumerate( { BMCWEB_LOG_DEBUG << "found object manager path " << object.first; - objectManagerPath = object.first; + connections[connection.first] = object.first; } } } |