diff options
author | Ed Tanous <ed@tanous.net> | 2024-04-07 02:03:49 +0300 |
---|---|---|
committer | Ed Tanous <ed@tanous.net> | 2024-04-11 19:38:16 +0300 |
commit | 4a7fbefdff330f06d5698a1e60ce893225cd389e (patch) | |
tree | 036f2c7795de1d48d06834d6b0ccbe1d0d5c9e79 /redfish-core/include/error_messages.hpp | |
parent | d9e89dfd49538c54d280dce3750f4af264cfd5fc (diff) | |
download | bmcweb-4a7fbefdff330f06d5698a1e60ce893225cd389e.tar.xz |
Fix large copies with url_view and segments_view
Despite these objects being called "view" they are still relatively
large, as clang-tidy correctly flags, and we ignore.
Change all function uses to capture by:
const boost::urls::url_view_base&
Which is the base class of all boost URL types, and any class (url,
url_view, etc) is convertible to that base.
Change-Id: I8ee2ea3f4cfba38331303a7e4eb520a2b6f8ba92
Signed-off-by: Ed Tanous <ed@tanous.net>
Diffstat (limited to 'redfish-core/include/error_messages.hpp')
-rw-r--r-- | redfish-core/include/error_messages.hpp | 61 |
1 files changed, 35 insertions, 26 deletions
diff --git a/redfish-core/include/error_messages.hpp b/redfish-core/include/error_messages.hpp index 91edc3c7cb..b692edaa78 100644 --- a/redfish-core/include/error_messages.hpp +++ b/redfish-core/include/error_messages.hpp @@ -17,7 +17,7 @@ #include "http_response.hpp" -#include <boost/url/url_view.hpp> +#include <boost/url/url_view_base.hpp> #include <nlohmann/json.hpp> #include <cstdint> @@ -71,9 +71,10 @@ void malformedJSON(crow::Response& res); * @param[in] arg1 Parameter of message that will replace %1 in its body. * * @returns Message ResourceMissingAtURI formatted to JSON */ -nlohmann::json resourceMissingAtURI(boost::urls::url_view arg1); +nlohmann::json resourceMissingAtURI(const boost::urls::url_view_base& arg1); -void resourceMissingAtURI(crow::Response& res, boost::urls::url_view arg1); +void resourceMissingAtURI(crow::Response& res, + const boost::urls::url_view_base& arg1); /** * @brief Formats ActionParameterValueFormatError message into JSON @@ -144,10 +145,11 @@ void unrecognizedRequestBody(crow::Response& res); * @param[in] arg2 Parameter of message that will replace %2 in its body. * * @returns Message ResourceAtUriUnauthorized formatted to JSON */ -nlohmann::json resourceAtUriUnauthorized(boost::urls::url_view arg1, +nlohmann::json resourceAtUriUnauthorized(const boost::urls::url_view_base& arg1, std::string_view arg2); -void resourceAtUriUnauthorized(crow::Response& res, boost::urls::url_view arg1, +void resourceAtUriUnauthorized(crow::Response& res, + const boost::urls::url_view_base& arg1, std::string_view arg2); /** @@ -292,10 +294,11 @@ void propertyValueOutOfRange(crow::Response& res, const nlohmann::json& arg1, * @param[in] arg1 Parameter of message that will replace %1 in its body. * * @returns Message ResourceAtUriInUnknownFormat formatted to JSON */ -nlohmann::json resourceAtUriInUnknownFormat(boost::urls::url_view arg1); +nlohmann::json + resourceAtUriInUnknownFormat(const boost::urls::url_view_base& arg1); void resourceAtUriInUnknownFormat(crow::Response& res, - boost::urls::url_view arg1); + const boost::urls::url_view_base& arg1); /** * @brief Formats ServiceDisabled message into JSON @@ -402,9 +405,10 @@ void resourceTypeIncompatible(crow::Response& res, std::string_view arg1, * @param[in] arg2 Parameter of message that will replace %2 in its body. * * @returns Message ResetRequired formatted to JSON */ -nlohmann::json resetRequired(boost::urls::url_view arg1, std::string_view arg2); +nlohmann::json resetRequired(const boost::urls::url_view_base& arg1, + std::string_view arg2); -void resetRequired(crow::Response& res, boost::urls::url_view arg1, +void resetRequired(crow::Response& res, const boost::urls::url_view_base& arg1, std::string_view arg2); /** @@ -457,13 +461,14 @@ void propertyValueConflict(crow::Response& res, std::string_view arg1, * @param[in] arg3 Parameter of message that will replace %3 in its body. * * @returns Message PropertyValueResourceConflict to JSON */ -nlohmann::json propertyValueResourceConflict(std::string_view arg1, - const nlohmann::json& arg2, - boost::urls::url_view arg3); +nlohmann::json + propertyValueResourceConflict(std::string_view arg1, + const nlohmann::json& arg2, + const boost::urls::url_view_base& arg3); void propertyValueResourceConflict(crow::Response& res, std::string_view arg1, const nlohmann::json& arg2, - boost::urls::url_view arg3); + const boost::urls::url_view_base& arg3); /** * @brief Formats PropertyValueExternalConflict message into JSON @@ -505,9 +510,10 @@ void propertyValueIncorrect(crow::Response& res, std::string_view arg1, * @param[in] arg1 Parameter of message that will replace %1 in its body. * * @returns Message ResourceCreationConflict formatted to JSON */ -nlohmann::json resourceCreationConflict(boost::urls::url_view arg1); +nlohmann::json resourceCreationConflict(const boost::urls::url_view_base& arg1); -void resourceCreationConflict(crow::Response& res, boost::urls::url_view arg1); +void resourceCreationConflict(crow::Response& res, + const boost::urls::url_view_base& arg1); /** * @brief Formats MaximumErrorsExceeded message into JSON @@ -600,10 +606,11 @@ void resourceNotFound(crow::Response& res, std::string_view arg1, * @param[in] arg1 Parameter of message that will replace %1 in its body. * * @returns Message CouldNotEstablishConnection formatted to JSON */ -nlohmann::json couldNotEstablishConnection(boost::urls::url_view arg1); +nlohmann::json + couldNotEstablishConnection(const boost::urls::url_view_base& arg1); void couldNotEstablishConnection(crow::Response& res, - boost::urls::url_view arg1); + const boost::urls::url_view_base& arg1); /** * @brief Formats PropertyNotWritable message into JSON @@ -683,11 +690,12 @@ void actionParameterNotSupported(crow::Response& res, std::string_view arg1, * @param[in] arg2 Parameter of message that will replace %2 in its body. * * @returns Message SourceDoesNotSupportProtocol formatted to JSON */ -nlohmann::json sourceDoesNotSupportProtocol(boost::urls::url_view arg1, - std::string_view arg2); +nlohmann::json + sourceDoesNotSupportProtocol(const boost::urls::url_view_base& arg1, + std::string_view arg2); void sourceDoesNotSupportProtocol(crow::Response& res, - boost::urls::url_view arg1, + const boost::urls::url_view_base& arg1, std::string_view arg2); /** @@ -719,9 +727,9 @@ void accountRemoved(crow::Response& res); * @param[in] arg1 Parameter of message that will replace %1 in its body. * * @returns Message AccessDenied formatted to JSON */ -nlohmann::json accessDenied(boost::urls::url_view arg1); +nlohmann::json accessDenied(const boost::urls::url_view_base& arg1); -void accessDenied(crow::Response& res, boost::urls::url_view arg1); +void accessDenied(crow::Response& res, const boost::urls::url_view_base& arg1); /** * @brief Formats QueryNotSupported message into JSON @@ -816,9 +824,9 @@ void noValidSession(crow::Response& res); * @param[in] arg1 Parameter of message that will replace %1 in its body. * * @returns Message InvalidObject formatted to JSON */ -nlohmann::json invalidObject(boost::urls::url_view arg1); +nlohmann::json invalidObject(const boost::urls::url_view_base& arg1); -void invalidObject(crow::Response& res, boost::urls::url_view arg1); +void invalidObject(crow::Response& res, const boost::urls::url_view_base& arg1); /** * @brief Formats ResourceInStandby message into JSON @@ -1055,9 +1063,10 @@ void queryParameterOutOfRange(crow::Response& res, std::string_view arg1, * * @returns Message PasswordChangeRequired formatted to JSON */ -nlohmann::json passwordChangeRequired(boost::urls::url_view arg1); +nlohmann::json passwordChangeRequired(const boost::urls::url_view_base& arg1); -void passwordChangeRequired(crow::Response& res, boost::urls::url_view arg1); +void passwordChangeRequired(crow::Response& res, + const boost::urls::url_view_base& arg1); /** * @brief Formats InvalidUpload message into JSON |