diff options
author | Ed Tanous <edtanous@google.com> | 2022-01-25 20:49:11 +0300 |
---|---|---|
committer | Ed Tanous <ed@tanous.net> | 2022-01-28 22:43:59 +0300 |
commit | 26f6976f3905d7b20690bbf794fba746c1929ed3 (patch) | |
tree | 7cfaea46d4e70ea7b46275195f7d7024cb999dac /redfish-core/include | |
parent | bb05f2227d53d590534d1df6e6a622e13cea76ae (diff) | |
download | bmcweb-26f6976f3905d7b20690bbf794fba746c1929ed3.tar.xz |
Enable readability-container-size-empty tests
This one is a little trivial, but it does help in readability.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I5366d4eec8af2f781b3bad804131ae2eb806e3aa
Diffstat (limited to 'redfish-core/include')
-rw-r--r-- | redfish-core/include/event_service_manager.hpp | 12 | ||||
-rw-r--r-- | redfish-core/include/utils/fw_utils.hpp | 2 |
2 files changed, 7 insertions, 7 deletions
diff --git a/redfish-core/include/event_service_manager.hpp b/redfish-core/include/event_service_manager.hpp index ee402b61ee..b8a916c10f 100644 --- a/redfish-core/include/event_service_manager.hpp +++ b/redfish-core/include/event_service_manager.hpp @@ -183,7 +183,7 @@ inline int getEventLogParams(const std::string& logEntry, boost::split(logEntryFields, entry, boost::is_any_of(","), boost::token_compress_on); // We need at least a MessageId to be valid - if (logEntryFields.size() < 1) + if (logEntryFields.empty()) { return -EINVAL; } @@ -451,7 +451,7 @@ class Subscription : public persistent_data::UserSubscription // If registryPrefixes list is empty, don't filter events // send everything. - if (registryPrefixes.size()) + if (!registryPrefixes.empty()) { auto obj = std::find(registryPrefixes.begin(), registryPrefixes.end(), registryName); @@ -463,7 +463,7 @@ class Subscription : public persistent_data::UserSubscription // If registryMsgIds list is empty, don't filter events // send everything. - if (registryMsgIds.size()) + if (!registryMsgIds.empty()) { auto obj = std::find(registryMsgIds.begin(), registryMsgIds.end(), messageKey); @@ -484,7 +484,7 @@ class Subscription : public persistent_data::UserSubscription } } - if (logEntryArray.size() < 1) + if (logEntryArray.empty()) { BMCWEB_LOG_DEBUG << "No log entries available to be transferred."; return; @@ -506,7 +506,7 @@ class Subscription : public persistent_data::UserSubscription std::string mrdUri = telemetry::metricReportDefinitionUri + ("/" + id); // Empty list means no filter. Send everything. - if (metricReportDefinitions.size()) + if (!metricReportDefinitions.empty()) { if (std::find(metricReportDefinitions.begin(), metricReportDefinitions.end(), @@ -1008,7 +1008,7 @@ class EventServiceManager // Search the resourceTypes list for the subscription. // If resourceTypes list is empty, don't filter events // send everything. - if (entry->resourceTypes.size()) + if (!entry->resourceTypes.empty()) { for (const auto& resource : entry->resourceTypes) { diff --git a/redfish-core/include/utils/fw_utils.hpp b/redfish-core/include/utils/fw_utils.hpp index 5477575bc7..027c85154a 100644 --- a/redfish-core/include/utils/fw_utils.hpp +++ b/redfish-core/include/utils/fw_utils.hpp @@ -55,7 +55,7 @@ inline void return; } - if (functionalFw.size() == 0) + if (functionalFw.empty()) { // Could keep going and try to populate SoftwareImages but // something is seriously wrong, so just fail |