diff options
| author | Ed Tanous <edtanous@google.com> | 2022-01-25 21:19:23 +0300 |
|---|---|---|
| committer | Ed Tanous <ed@tanous.net> | 2022-02-09 23:45:00 +0300 |
| commit | 9eb808c1a84a76e92b0e01fa95d3f160f38d7c3f (patch) | |
| tree | f3631a3f2a97fb0f048fb1dd5d295b867e8d37fc /redfish-core/include | |
| parent | b3db89663256a462e9c90bf260d5058014765137 (diff) | |
| download | bmcweb-9eb808c1a84a76e92b0e01fa95d3f160f38d7c3f.tar.xz | |
Enable readability-avoid-const-params-in-decls
This check involves explicitly declaring variables const when they're
declared auto, which helps in readability, and makes it more clear that
the variables are const.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I71198ea03850384a389a56ad26f2c4a48c75b148
Diffstat (limited to 'redfish-core/include')
| -rw-r--r-- | redfish-core/include/error_messages.hpp | 2 | ||||
| -rw-r--r-- | redfish-core/include/event_service_manager.hpp | 4 | ||||
| -rw-r--r-- | redfish-core/include/privileges.hpp | 2 | ||||
| -rw-r--r-- | redfish-core/include/utils/fw_utils.hpp | 2 |
4 files changed, 5 insertions, 5 deletions
diff --git a/redfish-core/include/error_messages.hpp b/redfish-core/include/error_messages.hpp index 8aa6ba6474..dcca3aa93e 100644 --- a/redfish-core/include/error_messages.hpp +++ b/redfish-core/include/error_messages.hpp @@ -91,7 +91,7 @@ void actionParameterValueFormatError(crow::Response& res, * @returns Message InternalError formatted to JSON */ nlohmann::json internalError(); -void internalError(crow::Response& res, const bmcweb::source_location location = +void internalError(crow::Response& res, bmcweb::source_location location = bmcweb::source_location::current()); /** diff --git a/redfish-core/include/event_service_manager.hpp b/redfish-core/include/event_service_manager.hpp index 4fb07ca235..ec294ae200 100644 --- a/redfish-core/include/event_service_manager.hpp +++ b/redfish-core/include/event_service_manager.hpp @@ -555,7 +555,7 @@ class Subscription : public persistent_data::UserSubscription } } - uint64_t getEventSeqNum() + uint64_t getEventSeqNum() const { return eventSeqNum; } @@ -751,7 +751,7 @@ class EventServiceManager } } - void updateSubscriptionData() + void updateSubscriptionData() const { persistent_data::EventServiceStore::getInstance() .eventServiceConfig.enabled = serviceEnabled; diff --git a/redfish-core/include/privileges.hpp b/redfish-core/include/privileges.hpp index f5bc8b68c2..160816fd93 100644 --- a/redfish-core/include/privileges.hpp +++ b/redfish-core/include/privileges.hpp @@ -260,7 +260,7 @@ inline bool isOperationAllowedWithPrivileges( { return true; } - for (auto& requiredPrivileges : operationPrivilegesRequired) + for (const auto& requiredPrivileges : operationPrivilegesRequired) { BMCWEB_LOG_DEBUG << "Checking operation privileges..."; if (userPrivileges.isSupersetOf(requiredPrivileges)) diff --git a/redfish-core/include/utils/fw_utils.hpp b/redfish-core/include/utils/fw_utils.hpp index a0758d925c..c05f8cbb05 100644 --- a/redfish-core/include/utils/fw_utils.hpp +++ b/redfish-core/include/utils/fw_utils.hpp @@ -68,7 +68,7 @@ inline void // example functionalFw: // v as 2 "/xyz/openbmc_project/software/ace821ef" // "/xyz/openbmc_project/software/230fb078" - for (auto& fw : functionalFw) + for (const auto& fw : functionalFw) { sdbusplus::message::object_path path(fw); std::string leaf = path.filename(); |