diff options
| author | Ed Tanous <edtanous@google.com> | 2022-01-07 20:30:41 +0300 |
|---|---|---|
| committer | Ed Tanous <ed@tanous.net> | 2022-01-12 22:00:37 +0300 |
| commit | d3a9e08452986b28c8024de2b0fdb3cadbf4411b (patch) | |
| tree | f9dfbc45cfdf3c58a9e03e5c8d98cc199c417243 /redfish-core/include | |
| parent | ca45aa3c416e55027b8d17078bac6493e81d564f (diff) | |
| download | bmcweb-d3a9e08452986b28c8024de2b0fdb3cadbf4411b.tar.xz | |
Enforce variable init
There were a few places we weren't initting our variables per cpp core
guidelines. Fix all of them, and enable checks for this.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Iba09924beb9fb26f597ff94d1cecbd6d6b1af912
Diffstat (limited to 'redfish-core/include')
| -rw-r--r-- | redfish-core/include/event_service_manager.hpp | 9 | ||||
| -rw-r--r-- | redfish-core/include/utils/systemd_utils.hpp | 2 |
2 files changed, 6 insertions, 5 deletions
diff --git a/redfish-core/include/event_service_manager.hpp b/redfish-core/include/event_service_manager.hpp index 7cb5cc7cb7..ee402b61ee 100644 --- a/redfish-core/include/event_service_manager.hpp +++ b/redfish-core/include/event_service_manager.hpp @@ -564,9 +564,9 @@ class Subscription : public persistent_data::UserSubscription class EventServiceManager { private: - bool serviceEnabled; - uint32_t retryAttempts; - uint32_t retryTimeoutInterval; + bool serviceEnabled = false; + uint32_t retryAttempts = 0; + uint32_t retryTimeoutInterval = 0; EventServiceManager() { @@ -1189,7 +1189,8 @@ class EventServiceManager std::size_t index = 0; while ((index + iEventSize) <= bytesTransferred) { - struct inotify_event event; + struct inotify_event event + {}; std::memcpy(&event, &readBuffer[index], iEventSize); if (event.wd == dirWatchDesc) { diff --git a/redfish-core/include/utils/systemd_utils.hpp b/redfish-core/include/utils/systemd_utils.hpp index 75bbe35806..ad157dc793 100644 --- a/redfish-core/include/utils/systemd_utils.hpp +++ b/redfish-core/include/utils/systemd_utils.hpp @@ -39,7 +39,7 @@ inline std::string getUuid() if (sd_id128_get_machine_app_specific(appId, &machineId) == 0) { - std::array<char, SD_ID128_STRING_MAX> str; + std::array<char, SD_ID128_STRING_MAX> str{}; ret = sd_id128_to_string(machineId, str.data()); ret.insert(8, 1, '-'); ret.insert(13, 1, '-'); |