summaryrefslogtreecommitdiff
path: root/redfish-core/lib/account_service.hpp
diff options
context:
space:
mode:
authorClaire Weinan <cweinan@google.com>2022-07-15 20:43:25 +0300
committerEd Tanous <ed@tanous.net>2022-09-09 06:00:53 +0300
commitc6fecdabd58b4c380caf1b83801ad4eb54922fff (patch)
tree2090c899b199c624bf9da0be25921430a3ef9193 /redfish-core/lib/account_service.hpp
parent6936afe4e687c8e94b7b1281fa9796101202871a (diff)
downloadbmcweb-c6fecdabd58b4c380caf1b83801ad4eb54922fff.tar.xz
LogService: Increase Fault Log timestamp precision
https://gerrit.openbmc.org/c/openbmc/bmcweb/+/55837 introduced support for microsecond-precision timestamps in bmcweb. Here we modify the Fault Log LogService (/redfish/v1/Managers/bmc/LogServices/FaultLog) to use microsecond-precision "Created" timestamps for its log entries. The motivation for increased precision is to increase the chance of having unique timestamps in case faults happen in quick succession. Unique timestamps are helpful for data center tools to keep log entries in chronological order and to track which entries have been seen before. The "Created" timestamp is based on the "Elapsed" property of the D-Bus interface xyz.openbmc_project.Time.EpochTime [1]. Dump entries must implement xyz.openbmc_project.Time.EpochTime [2]. Note: our intention is to increase timestamp precision to microseconds for all dump types. However at the moment the BMC dump and System dump managers (in phosphor-debug-collector module) are not populating EpochTime with microsecond precision as they should. So for now this patchset only increases precision for the FaultLog dump type. Changes to the Redfish tree: Clients will now see microsecond-precision instead of second-precision "Created" timestamps for fault log entries. Tested: Verified that Fault Log entries include microsecond-precision "Created" timestamps both when entries are retrieved individually and as a collection. Example commands: ``` curl -k -H "X-Auth-Token: $token" -X GET http://${bmc}/redfish/v1/Managers/bmc/LogServices/FaultLog/Entries curl -k -H "X-Auth-Token: $token" -X GET http://${bmc}/redfish/v1/Managers/bmc/LogServices/FaultLog/Entries/1 ``` Example timestamp output: "Created": "2022-07-12T15:56:33.017346+00:00", Also verified that BMC dump and System dump "Created" timestamps remain unchanged (they still use second-precision). Example commands: ``` curl -k -H "X-Auth-Token: $token" -X GET http://${bmc}/redfish/v1/Managers/bmc/LogServices/Dump/Entries curl -k -H "X-Auth-Token: $token" -X GET http://${bmc}/redfish/v1/Systems/system/LogServices/Dump/Entries ``` Redfish Service Validator succeeded on the following URI trees: /redfish/v1/Managers/bmc/LogServices/FaultLog /redfish/v1/Managers/bmc/LogServices/Dump [1] https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/yaml/xyz/openbmc_project/Time/EpochTime.interface.yaml [2] https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/yaml/xyz/openbmc_project/Dump/Entry.interface.yaml Signed-off-by: Claire Weinan <cweinan@google.com> Change-Id: I400a24def8dbeff1046b93f0bb64e04ae5038e9a
Diffstat (limited to 'redfish-core/lib/account_service.hpp')
0 files changed, 0 insertions, 0 deletions