diff options
| author | Ed Tanous <ed.tanous@intel.com> | 2019-07-10 02:24:22 +0300 |
|---|---|---|
| committer | Ed Tanous <ed.tanous@intel.com> | 2019-10-11 02:25:26 +0300 |
| commit | 271584ab78b4c1926f766aa26ddfde7da329059f (patch) | |
| tree | 08001912ea542de88b9c31f5d53f195dedd56988 /redfish-core/lib/certificate_service.hpp | |
| parent | 70ee8cbd4f3ec5b3e3c18967de221a9f3a70cd38 (diff) | |
| download | bmcweb-271584ab78b4c1926f766aa26ddfde7da329059f.tar.xz | |
Fix a bunch of warnings
using the list of warnings from here:
https://github.com/lefticus/cppbestpractices/blob/e73393f25a85f83fed7399d8b65cb117d00b2231/02-Use_the_Tools_Available.md#L100
Seems like a good place to start, and would improve things a bit
type-wise. This patchset attempts to correct all the issues in one
shot.
Tested:
It builds. Will test various subsystems that have been touched
Signed-off-by: Ed Tanous <ed.tanous@intel.com>
Change-Id: I588c26440e5a97f718a0f0ea74cc84107d53aa1e
Diffstat (limited to 'redfish-core/lib/certificate_service.hpp')
| -rw-r--r-- | redfish-core/lib/certificate_service.hpp | 16 |
1 files changed, 6 insertions, 10 deletions
diff --git a/redfish-core/lib/certificate_service.hpp b/redfish-core/lib/certificate_service.hpp index 111bcec598..89d563479c 100644 --- a/redfish-core/lib/certificate_service.hpp +++ b/redfish-core/lib/certificate_service.hpp @@ -458,13 +458,7 @@ class CertificateActionGenerateCSR : public Node *crow::connections::systemBus, match, [asyncResp, service, objectPath, certURI](sdbusplus::message::message &m) { - boost::system::error_code ec; - timeout.cancel(ec); - if (ec) - { - BMCWEB_LOG_ERROR << "error canceling timer " << ec; - csrMatcher = nullptr; - } + timeout.cancel(); if (m.is_method_error()) { BMCWEB_LOG_ERROR << "Dbus method error!!!"; @@ -489,7 +483,7 @@ class CertificateActionGenerateCSR : public Node } }); crow::connections::systemBus->async_method_call( - [asyncResp](const boost::system::error_code ec, + [asyncResp](const boost::system::error_code &ec, const std::string &path) { if (ec) { @@ -531,14 +525,16 @@ static void updateCertIssuerOrSubject(nlohmann::json &out, { break; } - const std::string_view key(tokenBegin, i - tokenBegin); + const std::string_view key(tokenBegin, + static_cast<size_t>(i - tokenBegin)); i++; tokenBegin = i; while (i != value.end() && *i != ',') { i++; } - const std::string_view val(tokenBegin, i - tokenBegin); + const std::string_view val(tokenBegin, + static_cast<size_t>(i - tokenBegin)); if (key == "L") { out["City"] = val; |