diff options
| author | Ed Tanous <ed@tanous.net> | 2020-07-18 23:51:21 +0300 |
|---|---|---|
| committer | Ed Tanous <ed@tanous.net> | 2020-08-17 23:54:37 +0300 |
| commit | 52cc112d962920b035c870127784bcbd98948fad (patch) | |
| tree | cef270a89373ad55b15578d9a52c5956aa5d3f7e /redfish-core/lib/pcie.hpp | |
| parent | d6c414f36c66b03f272f0cfc3a2e2d5dc0df1271 (diff) | |
| download | bmcweb-52cc112d962920b035c870127784bcbd98948fad.tar.xz | |
Remove middlewares
Middlewares, while kinda cool from an academic standpoint, make our
build times even worse than they already are. Given that we only really
use 1 real middleware today (token auth) and it needs to move into the
parser mode anyway (for security limiting buffer sizes), we might as well
use this as an opportunity to delete some code.
Some other things that happen:
1. Persistent data now moves out of the crow namespace
2. App is no longer a template
3. All request_routes implementations no longer become templates. This
should be a decent (unmeasured) win on compile times.
This commit was part of a commit previously called "various cleanups".
This separates ONLY the middleware deletion part of that.
Note, this also deletes about 400 lines of hard to understand code.
Change-Id: I4c19e25491a153a2aa2e4ef46fc797bcb5b3581a
Signed-off-by: Ed Tanous <ed@tanous.net>
Diffstat (limited to 'redfish-core/lib/pcie.hpp')
| -rw-r--r-- | redfish-core/lib/pcie.hpp | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/redfish-core/lib/pcie.hpp b/redfish-core/lib/pcie.hpp index ac2a2f9eb8..e2f35917b6 100644 --- a/redfish-core/lib/pcie.hpp +++ b/redfish-core/lib/pcie.hpp @@ -72,8 +72,7 @@ static inline void getPCIeDeviceList(std::shared_ptr<AsyncResp> asyncResp, class SystemPCIeDeviceCollection : public Node { public: - template <typename CrowApp> - SystemPCIeDeviceCollection(CrowApp& app) : + SystemPCIeDeviceCollection(App& app) : Node(app, "/redfish/v1/Systems/system/PCIeDevices/") { entityPrivileges = { @@ -107,7 +106,7 @@ class SystemPCIeDeviceCollection : public Node class SystemPCIeDevice : public Node { public: - SystemPCIeDevice(CrowApp& app) : + SystemPCIeDevice(App& app) : Node(app, "/redfish/v1/Systems/system/PCIeDevices/<str>/", std::string()) { @@ -192,8 +191,7 @@ class SystemPCIeDevice : public Node class SystemPCIeFunctionCollection : public Node { public: - template <typename CrowApp> - SystemPCIeFunctionCollection(CrowApp& app) : + SystemPCIeFunctionCollection(App& app) : Node(app, "/redfish/v1/Systems/system/PCIeDevices/<str>/PCIeFunctions/", std::string()) { @@ -287,7 +285,7 @@ class SystemPCIeFunctionCollection : public Node class SystemPCIeFunction : public Node { public: - SystemPCIeFunction(CrowApp& app) : + SystemPCIeFunction(App& app) : Node( app, "/redfish/v1/Systems/system/PCIeDevices/<str>/PCIeFunctions/<str>/", |