diff options
| author | Ed Tanous <edtanous@google.com> | 2023-04-25 01:28:50 +0300 |
|---|---|---|
| committer | Ed Tanous <ed@tanous.net> | 2023-05-16 19:05:33 +0300 |
| commit | ef4c65b741724d724452a3a0efe8dff0d450514a (patch) | |
| tree | 9667bdff1dd9d2dbeac94bc8bd46efd83177512b /redfish-core/lib/power_supply.hpp | |
| parent | a87c4180fd7f2127960fbc4c89c31b7659f0cfb8 (diff) | |
| download | bmcweb-ef4c65b741724d724452a3a0efe8dff0d450514a.tar.xz | |
Boost::urls::format
Boost 1.82 dropped a lovely new toy, boost::urls::format, which is a lot
like our urlFromPieces method, but better in that it makes the resulting
uris more readable, and allows doing things like fragments in a single
line instead of multiple. We should prefer it in some cases.
Tested:
Redfish service validator passes.
Spot checks of URLs work as expected.
Unit tests pass.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Ia7b38f0a95771c862507e7d5b4aa68aa1c98403c
Diffstat (limited to 'redfish-core/lib/power_supply.hpp')
| -rw-r--r-- | redfish-core/lib/power_supply.hpp | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/redfish-core/lib/power_supply.hpp b/redfish-core/lib/power_supply.hpp index 266bda2fef..430a29a632 100644 --- a/redfish-core/lib/power_supply.hpp +++ b/redfish-core/lib/power_supply.hpp @@ -6,6 +6,8 @@ #include "registries/privilege_registry.hpp" #include "utils/chassis_utils.hpp" +#include <boost/url/format.hpp> + #include <memory> #include <optional> #include <string> @@ -39,9 +41,8 @@ inline void asyncResp->res.jsonValue["@odata.type"] = "#PowerSupplyCollection.PowerSupplyCollection"; asyncResp->res.jsonValue["Name"] = "Power Supply Collection"; - asyncResp->res.jsonValue["@odata.id"] = - crow::utility::urlFromPieces("redfish", "v1", "Chassis", chassisId, - "PowerSubsystem", "PowerSupplies"); + asyncResp->res.jsonValue["@odata.id"] = boost::urls::format( + "/redfish/v1/Chassis/{}/PowerSubsystem/PowerSupplies", chassisId); asyncResp->res.jsonValue["Description"] = "The collection of PowerSupply resource instances."; asyncResp->res.jsonValue["Members"] = nlohmann::json::array(); |