diff options
| author | Chicago Duan <duanzhijia01@inspur.com> | 2021-04-15 11:59:25 +0300 |
|---|---|---|
| committer | Gunnar Mills <gmills@us.ibm.com> | 2021-04-21 06:37:18 +0300 |
| commit | 601af5ed832deae3f525064d94bb5a65b04554ae (patch) | |
| tree | 7a58a7841cad87ca5d02ebed98f075683a95a668 /redfish-core/lib/storage.hpp | |
| parent | d51e072fa60348422d6a145d76d7506de2bca4d6 (diff) | |
| download | bmcweb-601af5ed832deae3f525064d94bb5a65b04554ae.tar.xz | |
Redfish : Return after InternalError instead of Continue
"After setting response to internal error you should stop adding more content to response. Try to return instead of continuing a loop"
https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/39970/9/redfish-core/lib/pcie_slots.hpp#169
Signed-off-by: Chicago Duan <duanzhijia01@inspur.com>
Change-Id: Iadd3062ba7fef31ba61eea1e79eb3a903716b9e9
Diffstat (limited to 'redfish-core/lib/storage.hpp')
| -rw-r--r-- | redfish-core/lib/storage.hpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/redfish-core/lib/storage.hpp b/redfish-core/lib/storage.hpp index c2651d5e6b..34ef39a2f8 100644 --- a/redfish-core/lib/storage.hpp +++ b/redfish-core/lib/storage.hpp @@ -239,7 +239,7 @@ class Storage : public Node { // illegal property messages::internalError(asyncResp->res); - continue; + return; } object[propertyName] = *value; } @@ -385,7 +385,7 @@ class Drive : public Node { // illegal property messages::internalError(asyncResp->res); - continue; + return; } asyncResp->res.jsonValue[propertyName] = *value; } |