diff options
| author | Ed Tanous <ed@tanous.net> | 2020-07-25 22:02:03 +0300 |
|---|---|---|
| committer | Ed Tanous <ed@tanous.net> | 2020-08-17 23:54:37 +0300 |
| commit | cb13a39253848ece442971301ade9c09d98bf08e (patch) | |
| tree | 62f2a64fbc98d8ee635a0a81f3ef07afa541981d /redfish-core/lib/storage.hpp | |
| parent | 23a21a1cbed23ace4174664950e595df961e9e69 (diff) | |
| download | bmcweb-cb13a39253848ece442971301ade9c09d98bf08e.tar.xz | |
Enable unused variable warnings and resolve
This commit enables the "unused variables" warning in clang. Throughout
this, it did point out several issues that would've been functional
bugs, so I think it was worthwhile. It also cleaned up several unused
variable from old constructs that no longer exist.
Tested:
Built with clang. Code no longer emits warnings.
Downloaded bmcweb to system and pulled up the webui, observed webui
loads and logs in properly.
Change-Id: I51505f4222cc147d6f2b87b14d7e2ac4a74cafa8
Signed-off-by: Ed Tanous <ed@tanous.net>
Diffstat (limited to 'redfish-core/lib/storage.hpp')
| -rw-r--r-- | redfish-core/lib/storage.hpp | 22 |
1 files changed, 11 insertions, 11 deletions
diff --git a/redfish-core/lib/storage.hpp b/redfish-core/lib/storage.hpp index 9b1e2d7e33..ccd8ab8eda 100644 --- a/redfish-core/lib/storage.hpp +++ b/redfish-core/lib/storage.hpp @@ -38,8 +38,8 @@ class StorageCollection : public Node } private: - void doGet(crow::Response& res, const crow::Request& req, - const std::vector<std::string>& params) override + void doGet(crow::Response& res, const crow::Request&, + const std::vector<std::string>&) override { res.jsonValue["@odata.type"] = "#StorageCollection.StorageCollection"; res.jsonValue["@odata.id"] = "/redfish/v1/Systems/system/Storage"; @@ -66,8 +66,8 @@ class Storage : public Node } private: - void doGet(crow::Response& res, const crow::Request& req, - const std::vector<std::string>& params) override + void doGet(crow::Response& res, const crow::Request&, + const std::vector<std::string>&) override { res.jsonValue["@odata.type"] = "#Storage.v1_7_1.Storage"; res.jsonValue["@odata.id"] = "/redfish/v1/Systems/system/Storage/1"; @@ -289,7 +289,7 @@ class Drive : public Node } private: - void doGet(crow::Response& res, const crow::Request& req, + void doGet(crow::Response& res, const crow::Request&, const std::vector<std::string>& params) override { auto asyncResp = std::make_shared<AsyncResp>(res); @@ -353,12 +353,12 @@ class Drive : public Node const std::string& connectionName = connectionNames[0].first; crow::connections::systemBus->async_method_call( - [asyncResp](const boost::system::error_code ec, + [asyncResp](const boost::system::error_code ec2, const std::vector<std::pair< std::string, std::variant<bool, std::string, uint64_t>>>& propertiesList) { - if (ec) + if (ec2) { // this interface isn't necessary return; @@ -400,11 +400,11 @@ class Drive : public Node health->populate(); crow::connections::systemBus->async_method_call( - [asyncResp, path](const boost::system::error_code ec, + [asyncResp, path](const boost::system::error_code ec2, const std::variant<bool> present) { // this interface isn't necessary, only check it if we // get a good return - if (ec) + if (ec2) { return; } @@ -425,11 +425,11 @@ class Drive : public Node "Get", "xyz.openbmc_project.Inventory.Item", "Present"); crow::connections::systemBus->async_method_call( - [asyncResp](const boost::system::error_code ec, + [asyncResp](const boost::system::error_code ec2, const std::variant<bool> rebuilding) { // this interface isn't necessary, only check it if we // get a good return - if (ec) + if (ec2) { return; } |