diff options
| author | Ed Tanous <ed@tanous.net> | 2020-10-15 19:41:17 +0300 |
|---|---|---|
| committer | Ed Tanous <ed@tanous.net> | 2020-10-23 18:29:24 +0300 |
| commit | f23b729676559f539790580930b1ff3b0c05805b (patch) | |
| tree | c068573cefdfd5e6dff266fc6a9c1e530af9b491 /redfish-core/lib/storage.hpp | |
| parent | 04e438cbad66838724d78ce12f28aff1fb892a63 (diff) | |
| download | bmcweb-f23b729676559f539790580930b1ff3b0c05805b.tar.xz | |
Turn on ALL perf checks
1st, alphabetize the tidy-list for good housekeeping.
Next, enable all the clang-tidy performance checks, and resolve all the
issues. most of the issues boil down to:
1. Using std::move on const variables. This does nothing.
2. Passing big variables (like std::string) by value.
3. Using double quotes on a find call, which constructs an intermediate
string, rather than using the character overload.
Tested
Loaded on system, logged in successfully and pulled down webui-vue. No
new errors.
Walked the Redfish tree a bit, and observed no new problems.
Ran redfish service validator. Got no new failures (although there are
a lot of log service deprecation warnings that we should look at).
Signed-off-by: Ed Tanous <ed@tanous.net>
Change-Id: I2238958c4b22c1e554e09a0a1787c744bdbca43e
Diffstat (limited to 'redfish-core/lib/storage.hpp')
| -rw-r--r-- | redfish-core/lib/storage.hpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/redfish-core/lib/storage.hpp b/redfish-core/lib/storage.hpp index e89db652b2..7167503f81 100644 --- a/redfish-core/lib/storage.hpp +++ b/redfish-core/lib/storage.hpp @@ -101,7 +101,7 @@ class Storage : public Node for (const std::string& objpath : storageList) { - std::size_t lastPos = objpath.rfind("/"); + std::size_t lastPos = objpath.rfind('/'); if (lastPos == std::string::npos || (objpath.size() <= lastPos + 1)) { @@ -139,7 +139,7 @@ class Storage : public Node root = nlohmann::json::array(); for (const auto& [path, interfaceDict] : subtree) { - std::size_t lastPos = path.rfind("/"); + std::size_t lastPos = path.rfind('/'); if (lastPos == std::string::npos || (path.size() <= lastPos + 1)) { |