diff options
| author | Chicago Duan <duanzhijia01@inspur.com> | 2021-04-15 11:59:25 +0300 |
|---|---|---|
| committer | Gunnar Mills <gmills@us.ibm.com> | 2021-04-21 06:37:18 +0300 |
| commit | 601af5ed832deae3f525064d94bb5a65b04554ae (patch) | |
| tree | 7a58a7841cad87ca5d02ebed98f075683a95a668 /redfish-core/lib/systems.hpp | |
| parent | d51e072fa60348422d6a145d76d7506de2bca4d6 (diff) | |
| download | bmcweb-601af5ed832deae3f525064d94bb5a65b04554ae.tar.xz | |
Redfish : Return after InternalError instead of Continue
"After setting response to internal error you should stop adding more content to response. Try to return instead of continuing a loop"
https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/39970/9/redfish-core/lib/pcie_slots.hpp#169
Signed-off-by: Chicago Duan <duanzhijia01@inspur.com>
Change-Id: Iadd3062ba7fef31ba61eea1e79eb3a903716b9e9
Diffstat (limited to 'redfish-core/lib/systems.hpp')
| -rw-r--r-- | redfish-core/lib/systems.hpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/redfish-core/lib/systems.hpp b/redfish-core/lib/systems.hpp index f97dba29b6..8d76722e45 100644 --- a/redfish-core/lib/systems.hpp +++ b/redfish-core/lib/systems.hpp @@ -1760,7 +1760,7 @@ inline void if (!state) { messages::internalError(aResp->res); - continue; + return; } hostWatchdogTimer["FunctionEnabled"] = *state; @@ -1772,14 +1772,14 @@ inline void if (!s) { messages::internalError(aResp->res); - continue; + return; } std::string action = dbusToRfWatchdogAction(*s); if (action.empty()) { messages::internalError(aResp->res); - continue; + return; } hostWatchdogTimer["TimeoutAction"] = action; } |