summaryrefslogtreecommitdiff
path: root/redfish-core/lib/update_service.hpp
diff options
context:
space:
mode:
authorEd Tanous <edtanous@google.com>2022-01-25 21:28:56 +0300
committerEd Tanous <ed@tanous.net>2022-02-11 23:30:05 +0300
commite05aec50f10116e6dda7e377bc61799aa5b7c166 (patch)
tree964aedffefcc787029c571a83889247caa0d3968 /redfish-core/lib/update_service.hpp
parent213ffc701d838bece5893cda23475e7518bd6955 (diff)
downloadbmcweb-e05aec50f10116e6dda7e377bc61799aa5b7c166.tar.xz
Add readability-redundant-* checks
There's a number of redundancies in our code that clang can sanitize out. Fix the existing problems, and enable the checks. Signed-off-by: Ed Tanous <edtanous@google.com> Change-Id: Ie63d7b7f0777b702fbf1b23a24e1bed7b4f5183b
Diffstat (limited to 'redfish-core/lib/update_service.hpp')
-rw-r--r--redfish-core/lib/update_service.hpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/redfish-core/lib/update_service.hpp b/redfish-core/lib/update_service.hpp
index ba92748b3c..4b1852094f 100644
--- a/redfish-core/lib/update_service.hpp
+++ b/redfish-core/lib/update_service.hpp
@@ -263,7 +263,7 @@ static void monitorForSoftwareAvailable(
int timeoutTimeSeconds = 10)
{
// Only allow one FW update at a time
- if (fwUpdateInProgress != false)
+ if (fwUpdateInProgress)
{
if (asyncResp)
{
@@ -819,7 +819,7 @@ inline void requestRoutesSoftwareInventory(App& app)
std::string, std::vector<std::string>>>>& obj :
subtree)
{
- if (boost::ends_with(obj.first, *swId) != true)
+ if (!boost::ends_with(obj.first, *swId))
{
continue;
}