diff options
| author | Ed Tanous <edtanous@google.com> | 2022-01-25 21:28:56 +0300 |
|---|---|---|
| committer | Ed Tanous <ed@tanous.net> | 2022-02-11 23:30:05 +0300 |
| commit | e05aec50f10116e6dda7e377bc61799aa5b7c166 (patch) | |
| tree | 964aedffefcc787029c571a83889247caa0d3968 /redfish-core/lib/virtual_media.hpp | |
| parent | 213ffc701d838bece5893cda23475e7518bd6955 (diff) | |
| download | bmcweb-e05aec50f10116e6dda7e377bc61799aa5b7c166.tar.xz | |
Add readability-redundant-* checks
There's a number of redundancies in our code that clang can sanitize
out. Fix the existing problems, and enable the checks.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Ie63d7b7f0777b702fbf1b23a24e1bed7b4f5183b
Diffstat (limited to 'redfish-core/lib/virtual_media.hpp')
| -rw-r--r-- | redfish-core/lib/virtual_media.hpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/redfish-core/lib/virtual_media.hpp b/redfish-core/lib/virtual_media.hpp index d646698ad1..ab27fc7b8a 100644 --- a/redfish-core/lib/virtual_media.hpp +++ b/redfish-core/lib/virtual_media.hpp @@ -133,7 +133,7 @@ inline void } aResp->res.jsonValue["Inserted"] = *activeValue; - if (*activeValue == true) + if (*activeValue) { aResp->res.jsonValue["ConnectedVia"] = "Applet"; } @@ -400,7 +400,7 @@ inline bool } // optional param inserted must be true - if ((inserted != std::nullopt) && (*inserted != true)) + if ((inserted != std::nullopt) && !*inserted) { BMCWEB_LOG_ERROR << "Request action optional parameter Inserted must be true."; @@ -814,7 +814,7 @@ inline void requestNBDVirtualMediaRoutes(App& app) actionParams.inserted, actionParams.transferMethod, actionParams.transferProtocolType); - if (paramsValid == false) + if (!paramsValid) { return; } |