summaryrefslogtreecommitdiff
path: root/redfish-core/ut
diff options
context:
space:
mode:
authorGeorge Liu <liuxiwei@inspur.com>2021-09-30 15:24:46 +0300
committerGeorge Liu <liuxiwei@inspur.com>2021-10-21 06:31:51 +0300
commit287ece64bf9a8ee0c42f77cefce559054b488ae7 (patch)
treec411eeb8c8ba97d173ea6afabcc6872ccc6692bf /redfish-core/ut
parentd8e3c29a3b8626ed8072be4547a2bbcf7321c757 (diff)
downloadbmcweb-287ece64bf9a8ee0c42f77cefce559054b488ae7.tar.xz
Remove NTPServers duplicate values and null values
When saving the set NTPServers values from webUI, NTPServer may contain duplicate values and null values and update them to D-Bus. Now, need to parse and verify the value of the ntpServers attribute,and remove duplicate values and null values. Tested:save NTP and check it via D-Bus without this patch: NTPServers property as 3 "" "10.164.29.2" "10.164.29.2" with this patch: NTPServers property as 2 "" "10.164.29.2" Signed-off-by: George Liu <liuxiwei@inspur.com> Change-Id: I52291e4608efd635b179f3934c3d3e805afd2209
Diffstat (limited to 'redfish-core/ut')
-rw-r--r--redfish-core/ut/stl_utils_test.cpp21
1 files changed, 21 insertions, 0 deletions
diff --git a/redfish-core/ut/stl_utils_test.cpp b/redfish-core/ut/stl_utils_test.cpp
new file mode 100644
index 0000000000..a5115bd910
--- /dev/null
+++ b/redfish-core/ut/stl_utils_test.cpp
@@ -0,0 +1,21 @@
+#include "utils/stl_utils.hpp"
+
+#include <gmock/gmock.h>
+
+TEST(STLUtilesTest, RemoveDuplicates)
+{
+ std::vector<std::string> strVec = {"s1", "s4", "s1", "s2", "", "s3", "s3"};
+
+ auto iter =
+ redfish::stl_utils::firstDuplicate(strVec.begin(), strVec.end());
+ EXPECT_EQ(*iter, "s3");
+
+ redfish::stl_utils::removeDuplicate(strVec);
+
+ EXPECT_EQ(strVec.size(), 5);
+ EXPECT_EQ(strVec[0], "s1");
+ EXPECT_EQ(strVec[1], "s4");
+ EXPECT_EQ(strVec[2], "s2");
+ EXPECT_EQ(strVec[3], "");
+ EXPECT_EQ(strVec[4], "s3");
+}