diff options
| author | Ed Tanous <ed@tanous.net> | 2024-01-31 23:18:03 +0300 |
|---|---|---|
| committer | Ed Tanous <ed@tanous.net> | 2024-04-27 02:45:10 +0300 |
| commit | 3bfa3b29c0515a9e77c7c69fe072b7ff2e0fc302 (patch) | |
| tree | 261abe54a0fe45e84659bc5f644077ed68d62a08 /redfish-core | |
| parent | 9f217c26f58c0a99c18e7cac7b095dcf6068562d (diff) | |
| download | bmcweb-3bfa3b29c0515a9e77c7c69fe072b7ff2e0fc302.tar.xz | |
Move to process v2
Boost process v2 brings some significant benefits to our launching of
processes[1]. In bmcweb terms:
1. The code is radically simpler, which decreaeses compile times, and
reduces the scope for code scanning tools.
2. The code now uses standard asio pipes instead of inventing its own.
3. Separate compilation.
Tested:
We don't have a lot of unit tests for the virtual media stuff that I can
run, but we do have unit tests for credentials pipe, which in this
change have been ported over, so the feature works. Unit tests are
passing.
[1] https://www.boost.org/doc/libs/1_80_0/doc/html/boost_process/v2.html#boost_process.v2.introduction
Change-Id: Ia20226819d75ff6e492f8852185f0b73e8f5cf83
Signed-off-by: Ed Tanous <ed@tanous.net>
Diffstat (limited to 'redfish-core')
| -rw-r--r-- | redfish-core/lib/virtual_media.hpp | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/redfish-core/lib/virtual_media.hpp b/redfish-core/lib/virtual_media.hpp index 529b9dc5d9..37fb2045c9 100644 --- a/redfish-core/lib/virtual_media.hpp +++ b/redfish-core/lib/virtual_media.hpp @@ -25,7 +25,6 @@ #include "registries/privilege_registry.hpp" #include "utils/json_utils.hpp" -#include <boost/process/async_pipe.hpp> #include <boost/url/format.hpp> #include <boost/url/url_view.hpp> #include <boost/url/url_view_base.hpp> @@ -470,7 +469,7 @@ inline void doMountVmLegacy(const std::shared_ptr<bmcweb::AsyncResp>& asyncResp, // Open pipe secretPipe = std::make_shared<CredentialsPipe>( crow::connections::systemBus->get_io_context()); - fd = secretPipe->fd(); + fd = secretPipe->releaseFd(); // Pass secret over pipe secretPipe->asyncWrite( |