summaryrefslogtreecommitdiff
path: root/redfish-core
diff options
context:
space:
mode:
authorRichard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>2019-11-08 14:29:40 +0300
committerRichard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>2019-11-09 10:41:32 +0300
commitcb3e11fadd77b04f5b26aefbde18411625e5e304 (patch)
tree0266725bf7c1a3f40aba067f6402172414139259 /redfish-core
parent4380545ee6b3985f30060e4828fe5ac3a1e3475e (diff)
downloadbmcweb-cb3e11fadd77b04f5b26aefbde18411625e5e304.tar.xz
Remove priv-callback support from bmcweb
priv-callback is valid only for IPMI modem callback, which was never used, and it's decided to deprecate the same https://gerrit.openbmc-project.xyz/#/c/openbmc/docs/+/26839/ Removing the support in redfish now. Tested: 1. Verified callback role was not in list in Get of https://<BMC IP>/redfish/v1/AccountService/Roles/ 2. Redfish validator passed for this change. Change-Id: Ia16fb584a07bbdf29197cd5dd54e7a9682627c19 Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>
Diffstat (limited to 'redfish-core')
-rw-r--r--redfish-core/lib/account_service.hpp8
-rw-r--r--redfish-core/lib/roles.hpp8
2 files changed, 0 insertions, 16 deletions
diff --git a/redfish-core/lib/account_service.hpp b/redfish-core/lib/account_service.hpp
index 0658f3ff3b..fa10c04dd3 100644
--- a/redfish-core/lib/account_service.hpp
+++ b/redfish-core/lib/account_service.hpp
@@ -78,10 +78,6 @@ inline std::string getRoleIdFromPrivilege(std::string_view role)
{
return "Administrator";
}
- else if (role == "priv-callback")
- {
- return "Callback";
- }
else if (role == "priv-user")
{
return "ReadOnly";
@@ -98,10 +94,6 @@ inline std::string getPrivilegeFromRoleId(std::string_view role)
{
return "priv-admin";
}
- else if (role == "Callback")
- {
- return "priv-callback";
- }
else if (role == "ReadOnly")
{
return "priv-user";
diff --git a/redfish-core/lib/roles.hpp b/redfish-core/lib/roles.hpp
index d170a5c358..4256c7ec47 100644
--- a/redfish-core/lib/roles.hpp
+++ b/redfish-core/lib/roles.hpp
@@ -28,10 +28,6 @@ inline std::string getRoleFromPrivileges(std::string_view priv)
{
return "Administrator";
}
- else if (priv == "priv-callback")
- {
- return "Callback";
- }
else if (priv == "priv-user")
{
return "ReadOnly";
@@ -59,10 +55,6 @@ inline bool getAssignedPrivFromRole(std::string_view role,
{
privArray = {"Login", "ConfigureSelf"};
}
- else if (role == "Callback")
- {
- privArray = {"Login"};
- }
else
{
return false;