diff options
| author | Ed Tanous <edtanous@google.com> | 2022-12-21 20:30:16 +0300 |
|---|---|---|
| committer | Ed Tanous <ed@tanous.net> | 2023-01-17 19:44:09 +0300 |
| commit | cf9e417d3b88eb12f8c6a9d007d6a63c3eeb94f4 (patch) | |
| tree | 45344ba086e93c7ff5589f9328b2c942679114ba /src | |
| parent | 0d9462115c53d478ed757ca4a3cccd0acf593781 (diff) | |
| download | bmcweb-cf9e417d3b88eb12f8c6a9d007d6a63c3eeb94f4.tar.xz | |
Add check for globals
We don't follow this cpp core guidelines rule well. This is something
that we should aspire to cleaning up in the future, but for the moment,
lets turn the rule on in clang-tidy to stop the bleeding, add ignores
for the things that we know need some better abstractions, and work on
these over time.
Most of this commit is just adding NOLINTNEXTLINE exceptions for all of
our globals. There was one case in the sensor code where clang
correctly noted that those globals weren't actually const, which got
missed because of the use of auto.
Tested: CI should be good enough for this. Passes clang-tidy.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Ieda08fee69a3b209d4b3e9771809a6c41524f066
Diffstat (limited to 'src')
| -rw-r--r-- | src/dbus_singleton.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/dbus_singleton.cpp b/src/dbus_singleton.cpp index f78164fbe2..726c3d4bb5 100644 --- a/src/dbus_singleton.cpp +++ b/src/dbus_singleton.cpp @@ -6,7 +6,7 @@ namespace crow { namespace connections { - +// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables) sdbusplus::asio::connection* systemBus = nullptr; } // namespace connections |