diff options
| author | Patrick Williams <patrick@stwcx.xyz> | 2023-05-11 01:29:00 +0300 |
|---|---|---|
| committer | Patrick Williams <patrick@stwcx.xyz> | 2023-05-12 19:07:15 +0300 |
| commit | 26b3630b181d1093483e4d5ebe6aeeb91a6a2976 (patch) | |
| tree | 67cc0619cb1085f29a81a64127b7742337dde98d /test/include | |
| parent | ad539545b8638d934f917e4d711fa7ef48011326 (diff) | |
| download | bmcweb-26b3630b181d1093483e4d5ebe6aeeb91a6a2976.tar.xz | |
ibm-locks: shut up clang-tidy by disabling code
There is code in ibm/locks that has had clang-tidy warnings disabled
for a while due to multiple safety and endianness issues. The code
has not been fixed in a while and with clang-16 it is unable to be
exempted further. Disable it until someone who cares can fix this
in the proper way.
```
../include/ibm/locks.hpp:522:14: error: 'p' is an unsafe pointer used for buffer access [-Werror,-Wunsafe-buffer-usage]
uint8_t* p = reinterpret_cast<uint8_t*>(&resourceId1);
~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/ibm/locks.hpp:527:25: note: used in buffer access here
uint8_t pPosition = p[position];
^
../include/ibm/locks.hpp:524:14: error: 'q' is an unsafe pointer used for buffer access [-Werror,-Wunsafe-buffer-usage]
uint8_t* q = reinterpret_cast<uint8_t*>(&resourceId2);
~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/ibm/locks.hpp:529:25: note: used in buffer access here
uint8_t qPosition = q[position];
```
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I8a7fcbed1099419ad1715c86ffcbfef20820251e
Diffstat (limited to 'test/include')
| -rw-r--r-- | test/include/ibm/lock_test.cpp | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/test/include/ibm/lock_test.cpp b/test/include/ibm/lock_test.cpp index 33c5354f64..327ce6869c 100644 --- a/test/include/ibm/lock_test.cpp +++ b/test/include/ibm/lock_test.cpp @@ -167,7 +167,7 @@ TEST_F(LockTest, MultiRequestWithConflictduetoSameSegmentLength) const LockRequests& t = request; EXPECT_TRUE(lockManager.isConflictRequest(t)); } - +#if 0 // Comment out due to bad code in include/ibm/locks.hpp TEST_F(LockTest, MultiRequestWithoutConflictduetoDifferentSegmentData) { MockLock lockManager; @@ -203,6 +203,7 @@ TEST_F(LockTest, MultiRequestWithConflictduetoSameSegmentData) const LockRequests& t = request; EXPECT_TRUE(lockManager.isConflictRequest(t)); } +#endif TEST_F(LockTest, MultiRequestWithoutConflictduetoDifferentSegmentLength) { @@ -243,6 +244,7 @@ TEST_F(LockTest, MultiRequestWithoutConflictduetoReadLocktypeAndLockall) EXPECT_FALSE(lockManager.isConflictRequest(t)); } +#if 0 // Comment out due to bad code in include/ibm/locks.hpp TEST_F(LockTest, RequestConflictedWithLockTableEntries) { MockLock lockManager; @@ -257,6 +259,7 @@ TEST_F(LockTest, RequestConflictedWithLockTableEntries) // Return a Conflict EXPECT_TRUE(rc2.first); } +#endif TEST_F(LockTest, RequestNotConflictedWithLockTableEntries) { |