diff options
Diffstat (limited to 'redfish-core/include/event_service_manager.hpp')
| -rw-r--r-- | redfish-core/include/event_service_manager.hpp | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/redfish-core/include/event_service_manager.hpp b/redfish-core/include/event_service_manager.hpp index 55485c63e8..051e49506e 100644 --- a/redfish-core/include/event_service_manager.hpp +++ b/redfish-core/include/event_service_manager.hpp @@ -95,7 +95,7 @@ static const Message* std::span<const MessageEntry>::iterator messageIt = std::find_if(registry.begin(), registry.end(), [&messageKey](const MessageEntry& messageEntry) { - return !messageKey.compare(messageEntry.first); + return messageKey.compare(messageEntry.first) == 0; }); if (messageIt != registry.end()) { @@ -708,7 +708,7 @@ class EventServiceManager std::string id; int retry = 3; - while (retry) + while (retry != 0) { id = std::to_string(dist(gen)); if (gen.error()) @@ -764,7 +764,7 @@ class EventServiceManager if (serviceEnabled != cfg.enabled) { serviceEnabled = cfg.enabled; - if (serviceEnabled && noOfMetricReportSubscribers) + if (serviceEnabled && noOfMetricReportSubscribers != 0U) { registerMetricReportSignal(); } @@ -827,7 +827,7 @@ class EventServiceManager if (noOfMetricReportSubscribers != metricReportSubCount) { noOfMetricReportSubscribers = metricReportSubCount; - if (noOfMetricReportSubscribers) + if (noOfMetricReportSubscribers != 0U) { registerMetricReportSignal(); } @@ -860,7 +860,7 @@ class EventServiceManager std::string id; int retry = 3; - while (retry) + while (retry != 0) { id = std::to_string(dist(gen)); if (gen.error()) @@ -989,7 +989,7 @@ class EventServiceManager void sendEvent(const nlohmann::json& eventMessageIn, const std::string& origin, const std::string& resType) { - if (!serviceEnabled || !noOfEventLogSubscribers) + if (!serviceEnabled || (noOfEventLogSubscribers == 0u)) { BMCWEB_LOG_DEBUG << "EventService disabled or no Subscriptions."; return; @@ -1122,7 +1122,7 @@ class EventServiceManager continue; } - if (!serviceEnabled || !noOfEventLogSubscribers) + if (!serviceEnabled || noOfEventLogSubscribers == 0) { // If Service is not enabled, no need to compute // the remaining items below. @@ -1153,7 +1153,7 @@ class EventServiceManager messageKey, messageArgs); } - if (!serviceEnabled || !noOfEventLogSubscribers) + if (!serviceEnabled || noOfEventLogSubscribers == 0) { BMCWEB_LOG_DEBUG << "EventService disabled or no Subscriptions."; return; @@ -1340,7 +1340,7 @@ class EventServiceManager const telemetry::TimestampReadings* readings = std::get_if<telemetry::TimestampReadings>(&found->second); - if (!readings) + if (readings == nullptr) { BMCWEB_LOG_INFO << "Failed to get Readings from Report properties"; return; |