From 4a7fbefdff330f06d5698a1e60ce893225cd389e Mon Sep 17 00:00:00 2001 From: Ed Tanous Date: Sat, 6 Apr 2024 16:03:49 -0700 Subject: Fix large copies with url_view and segments_view Despite these objects being called "view" they are still relatively large, as clang-tidy correctly flags, and we ignore. Change all function uses to capture by: const boost::urls::url_view_base& Which is the base class of all boost URL types, and any class (url, url_view, etc) is convertible to that base. Change-Id: I8ee2ea3f4cfba38331303a7e4eb520a2b6f8ba92 Signed-off-by: Ed Tanous --- .clang-tidy | 1 - 1 file changed, 1 deletion(-) (limited to '.clang-tidy') diff --git a/.clang-tidy b/.clang-tidy index 0027ca00b2..41643f5fcd 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -357,6 +357,5 @@ CheckOptions: - { key: readability-identifier-naming.FunctionIgnoredRegexp, value: (BMCWEB_LOG_DEBUG|BMCWEB_LOG_INFO|BMCWEB_LOG_WARNING|BMCWEB_LOG_ERROR|BMCWEB_LOG_CRITICAL) } - { key: readability-identifier-naming.StructIgnoredRegexp, value: (BMCWEB_LOG_DEBUG|BMCWEB_LOG_INFO|BMCWEB_LOG_WARNING|BMCWEB_LOG_ERROR|BMCWEB_LOG_CRITICAL) } - { key: cppcoreguidelines-macro-usage.AllowedRegexp, value: DEBUG*|NLOHMANN_JSON_SERIALIZE_ENUM } - - { key: performance-unnecessary-value-param.AllowedTypes, value: ((segments_view)|(url_view)) } - { key: cppcoreguidelines-rvalue-reference-param-not-moved.IgnoreUnnamedParams, value: true } - { key: misc-include-cleaner.IgnoreHeaders, value: ((nlohmann/json_fwd.hpp)|(boost/.*/src.hpp)|(boost/.*/detail/.*)|(nlohmann/detail/.*)|(stdio.h)|(ranges)|(bits/chrono.h)|(boost/system/error_code.hpp)) } -- cgit v1.2.3