From 6ea9076048028a4adfdbdd2606698bffc81203d3 Mon Sep 17 00:00:00 2001 From: Ed Tanous Date: Sun, 7 Apr 2024 08:38:44 -0700 Subject: Rework logger to create compile time errors The logger changes to move to std::format incidentally caused format errors to no longer be flagged at compile time. The example here[1] shows that the latest gcc/c++ gave us a way to solve this, using std::format_string. This incidentally shows two places where we got the format arguments wrong, so fix them. [1] https://stackoverflow.com/questions/72795189/how-can-i-wrap-stdformat-with-my-own-template-function Change-Id: Id884200e2c98eeaf5ef8db6c1d6362ede2ffb858 Signed-off-by: Ed Tanous --- .clang-tidy | 1 + 1 file changed, 1 insertion(+) (limited to '.clang-tidy') diff --git a/.clang-tidy b/.clang-tidy index 5b530c3791..0027ca00b2 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -355,6 +355,7 @@ CheckOptions: - { key: readability-identifier-naming.NamespaceCase, value: lower_case } - { key: readability-identifier-naming.StructCase, value: CamelCase } - { key: readability-identifier-naming.FunctionIgnoredRegexp, value: (BMCWEB_LOG_DEBUG|BMCWEB_LOG_INFO|BMCWEB_LOG_WARNING|BMCWEB_LOG_ERROR|BMCWEB_LOG_CRITICAL) } + - { key: readability-identifier-naming.StructIgnoredRegexp, value: (BMCWEB_LOG_DEBUG|BMCWEB_LOG_INFO|BMCWEB_LOG_WARNING|BMCWEB_LOG_ERROR|BMCWEB_LOG_CRITICAL) } - { key: cppcoreguidelines-macro-usage.AllowedRegexp, value: DEBUG*|NLOHMANN_JSON_SERIALIZE_ENUM } - { key: performance-unnecessary-value-param.AllowedTypes, value: ((segments_view)|(url_view)) } - { key: cppcoreguidelines-rvalue-reference-param-not-moved.IgnoreUnnamedParams, value: true } -- cgit v1.2.3