From dd72e87b0588dcc2e2732cd47e5c9468a6386200 Mon Sep 17 00:00:00 2001 From: Claire Weinan Date: Mon, 15 Aug 2022 14:20:06 -0700 Subject: Fix function name handleLogServicesCollectionGet Renamed handleLogServicesCollectionGet() to handleBMCLogServicesCollectionGet() (added "BMC"). handleLogServicesCollectionGet() was a function first introduced in https://gerrit.openbmc.org/c/openbmc/bmcweb/+/53175 but the function name was accidentally made to be too broad. The function only handles outputting the collection of LogServices specifically under /redfish/v1/Managers/bmc/LogServices. No expected client impact. Tested: Redfish Service Validator succeeded on the following URI: /redfish/v1/Managers/bmc/LogServices/ Signed-off-by: Claire Weinan Change-Id: I4648db2eaa5417c2428b514fdda1dbf82af0b3f0 --- redfish-core/lib/log_services.hpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/redfish-core/lib/log_services.hpp b/redfish-core/lib/log_services.hpp index ee3ccfc6c4..c3b659e70d 100644 --- a/redfish-core/lib/log_services.hpp +++ b/redfish-core/lib/log_services.hpp @@ -2004,7 +2004,7 @@ inline void requestRoutesSystemHostLoggerLogEntry(App& app) constexpr char const* dumpManagerIface = "xyz.openbmc_project.Collection.DeleteAll"; -inline void handleLogServicesCollectionGet( +inline void handleBMCLogServicesCollectionGet( crow::App& app, const crow::Request& req, const std::shared_ptr& asyncResp) { @@ -2039,7 +2039,7 @@ inline void handleLogServicesCollectionGet( if (ec) { BMCWEB_LOG_ERROR - << "handleLogServicesCollectionGet respHandler got error " + << "handleBMCLogServicesCollectionGet respHandler got error " << ec; // Assume that getting an error simply means there are no dump // LogServices. Return without adding any error response. @@ -2083,7 +2083,7 @@ inline void requestRoutesBMCLogServiceCollection(App& app) BMCWEB_ROUTE(app, "/redfish/v1/Managers/bmc/LogServices/") .privileges(redfish::privileges::getLogServiceCollection) .methods(boost::beast::http::verb::get)( - std::bind_front(handleLogServicesCollectionGet, std::ref(app))); + std::bind_front(handleBMCLogServicesCollectionGet, std::ref(app))); } inline void requestRoutesBMCJournalLogService(App& app) -- cgit v1.2.3