From 55c7b7a2e58779580f33046d2dd8649243776700 Mon Sep 17 00:00:00 2001 From: Ed Tanous Date: Tue, 22 May 2018 15:27:24 -0700 Subject: Move over to upstream c++ style This patchset moves bmcweb over to the upstream style naming conventions for variables, classes, and functions, as well as imposes the latest clang-format file. This changeset was mostly built automatically by the included .clang-tidy file, which has the ability to autoformat and auto rename variables. At some point in the future I would like to see this in greater use, but for now, we will impose it on bmcweb, and see how it goes. Tested: Code still compiles, and appears to run, although other issues are possible and likely. Change-Id: If422a2e36df924e897736b3feffa89f411d9dac1 Signed-off-by: Ed Tanous --- README.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'README.md') diff --git a/README.md b/README.md index f5e937de92..080e85a374 100644 --- a/README.md +++ b/README.md @@ -21,17 +21,17 @@ The crow project has had a number of additions to make it more useful for use in + Crow server now calls stop before destruction of the Crow app object. + Fixed a bug where timed out websockets would seg fault the system by accessing a destroyed socket object without null checks when in SSL mode. + Added a TestSocketAdapter class that could be used to unit test server behavior without utilizing a socket. -+ Added the "get_routes" call to both the app and the routing Trie class that allows consumers to poll the server for all (or a subset of) registered web routes in the system. ++ Added the "getRoutes" call to both the app and the routing Trie class that allows consumers to poll the server for all (or a subset of) registered web routes in the system. + Hardcoded the websocket implementation for binary mode, instead of leaving protocol unspecified. + Move most uses of std::unordered_map to boost::flat_map to lower memory consumption, and (in some cases) to improve memory locality. -+ Adjust the add_headers mechanism to use a fixed string instead of a full map implementation to avoid unnecessary mallocs and reduce the number of scatter gather buffers on an http response. ++ Adjust the addHeaders mechanism to use a fixed string instead of a full map implementation to avoid unnecessary mallocs and reduce the number of scatter gather buffers on an http response. + Change server name header from Crow/0.1 to iBMC + Starts the http server io_service inside the main thread, instead of creating a new thread. -+ Removes all CROW_MSVC_WORKAROUND flags. ++ Removes all BMCWEB_MSVC_WORKAROUND flags. + Removes the behavior that causes a 301 redirect for paths that end in "/", and simply returns the endpoint requested. This was done for redfish compatibility. + Removes the built in crow/json.hpp package and adds nlohmann json package as the first class json package for crow. + Move uses of boost::array to std::array where possible. -+ Add the ability to get a reference to the crow::request object on websocket connection to allow checking header values. ++ Add the ability to get a reference to the crow::Request object on websocket connection to allow checking header values. + Patch http handler to call middlewares on websocket connections to allow authentication to be applied appropriately. + Adds an is_secure flag to provide information about whether or not the payload was delivered over ssl. -- cgit v1.2.3