From 47f2934cc509e420e5617a96158e76829746b835 Mon Sep 17 00:00:00 2001
From: Ed Tanous <ed@tanous.net>
Date: Tue, 19 Mar 2024 12:18:06 -0700
Subject: Fix redundant init issues

clang-tidy-18 must've fixed their checking for these in headers.
Resolve as the robot commands.

Tested: Noop changes made by tidy.  Code compiles.

Change-Id: I1de7686c597deffb0df91c30dae1a29f9ba7900e
Signed-off-by: Ed Tanous <ed@tanous.net>
---
 http/http2_connection.hpp | 4 ++--
 http/http_request.hpp     | 8 ++++----
 2 files changed, 6 insertions(+), 6 deletions(-)

(limited to 'http')

diff --git a/http/http2_connection.hpp b/http/http2_connection.hpp
index 7903ec93b1..749ac282ef 100644
--- a/http/http2_connection.hpp
+++ b/http/http2_connection.hpp
@@ -38,9 +38,9 @@ namespace crow
 
 struct Http2StreamData
 {
-    Request req{};
+    Request req;
     std::optional<bmcweb::HttpBody::reader> reqReader;
-    Response res{};
+    Response res;
     std::optional<bmcweb::HttpBody::writer> writer;
 };
 
diff --git a/http/http_request.hpp b/http/http_request.hpp
index ee940d658b..a3c8fd8d0e 100644
--- a/http/http_request.hpp
+++ b/http/http_request.hpp
@@ -22,17 +22,17 @@ struct Request
     boost::beast::http::request<bmcweb::HttpBody> req;
 
   private:
-    boost::urls::url urlBase{};
+    boost::urls::url urlBase;
 
   public:
     bool isSecure{false};
 
-    boost::asio::io_context* ioService{};
-    boost::asio::ip::address ipAddress{};
+    boost::asio::io_context* ioService = nullptr;
+    boost::asio::ip::address ipAddress;
 
     std::shared_ptr<persistent_data::UserSession> session;
 
-    std::string userRole{};
+    std::string userRole;
     Request(boost::beast::http::request<bmcweb::HttpBody> reqIn,
             std::error_code& ec) :
         req(std::move(reqIn))
-- 
cgit v1.2.3