From 4e08751b5debb2451ced16ee10dfed2c863edaa7 Mon Sep 17 00:00:00 2001 From: Ed Tanous Date: Mon, 28 Sep 2020 18:41:25 -0700 Subject: modernize ibm management console There was some modernization problems in the IBM console. These are all minor, and unlikely to cause problems. The issues were: 1. Trivial destructors need to use the = default syntax 2. Several loops can be simplified into range based for loops 3. push_back should not be paired with make_pair. emplace_back should be used instead. Change-Id: I71b1d5437249d896a6f95c211e176deb676f985d --- include/ibm/locks.hpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'include/ibm/locks.hpp') diff --git a/include/ibm/locks.hpp b/include/ibm/locks.hpp index 162abeeefa..e986f32f1e 100644 --- a/include/ibm/locks.hpp +++ b/include/ibm/locks.hpp @@ -188,8 +188,7 @@ class Lock return lockObject; } - virtual ~Lock() - {} + virtual ~Lock() = default; }; inline bool Lock::createPersistentLockFilePath() @@ -293,7 +292,7 @@ inline RcGetLockList Lock::getLockList(const ListOfSessionIds& listSessionId) // Push the whole lock record into a vector for returning // the json - lockList.push_back(std::make_pair(it->first, it->second)); + lockList.emplace_back(it->first, it->second); } // Go to next entry in map it++; -- cgit v1.2.3