From ca45aa3c416e55027b8d17078bac6493e81d564f Mon Sep 17 00:00:00 2001 From: Ed Tanous Date: Fri, 7 Jan 2022 09:28:45 -0800 Subject: Enable checks for pointer arithmetic Quite a few places we've disobeyed this rule, so simply ignore them for now to avoid new issues popping up. Signed-off-by: Ed Tanous Change-Id: I3e518a8e8742279afb3ad1a9dad54006ed109fb1 --- include/ibm/locks.hpp | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) (limited to 'include/ibm/locks.hpp') diff --git a/include/ibm/locks.hpp b/include/ibm/locks.hpp index 4fbb50360d..5a86d09dec 100644 --- a/include/ibm/locks.hpp +++ b/include/ibm/locks.hpp @@ -535,9 +535,14 @@ inline bool Lock::checkByte(uint64_t resourceId1, uint64_t resourceId2, // NOLINTNEXTLINE(cppcoreguidelines-pro-type-reinterpret-cast) uint8_t* q = reinterpret_cast(&resourceId2); - BMCWEB_LOG_DEBUG << "Comparing bytes " << std::to_string(p[position]) << "," - << std::to_string(q[position]); - if (p[position] != q[position]) + // NOLINTNEXTLINE(cppcoreguidelines-pro-bounds-pointer-arithmetic) + uint8_t pPosition = p[position]; + // NOLINTNEXTLINE(cppcoreguidelines-pro-bounds-pointer-arithmetic) + uint8_t qPosition = q[position]; + + BMCWEB_LOG_DEBUG << "Comparing bytes " << std::to_string(pPosition) << "," + << std::to_string(qPosition); + if (pPosition != qPosition) { return false; } -- cgit v1.2.3