From 4b242749b31b16c663fe2e95ad7dbc6a2f3ca973 Mon Sep 17 00:00:00 2001 From: Ed Tanous Date: Thu, 11 May 2023 09:51:51 -0700 Subject: Make all std::regex instances static Per [1] we really shouldn't be using regex. In the cases we do, it's a HUUUUUGE performance benefit to be compiling the regex ONCE. The only downside is a slight increase in memory usage. [1]: https://github.com/openbmc/bmcweb/issues/176 Signed-off-by: Ed Tanous Change-Id: I8644b8a07810349fb60bfa0258a13e815912a38e --- include/openbmc_dbus_rest.hpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'include/openbmc_dbus_rest.hpp') diff --git a/include/openbmc_dbus_rest.hpp b/include/openbmc_dbus_rest.hpp index 51257642cb..0fbef04921 100644 --- a/include/openbmc_dbus_rest.hpp +++ b/include/openbmc_dbus_rest.hpp @@ -101,7 +101,7 @@ const constexpr char* forbiddenResDesc = inline bool validateFilename(const std::string& filename) { - std::regex validFilename(R"(^[\w\- ]+(\.?[\w\- ]*)$)"); + static std::regex validFilename(R"(^[\w\- ]+(\.?[\w\- ]*)$)"); return std::regex_match(filename, validFilename); } @@ -2562,7 +2562,7 @@ inline void requestRoutes(App& app) // Filename should be in alphanumeric, dot and underscore // Its based on phosphor-debug-collector application // dumpfile format - std::regex dumpFileRegex("[a-zA-Z0-9\\._]+"); + static std::regex dumpFileRegex("[a-zA-Z0-9\\._]+"); if (!std::regex_match(dumpFileName, dumpFileRegex)) { BMCWEB_LOG_ERROR << "Invalid dump filename " << dumpFileName; -- cgit v1.2.3