From f79ce6a8f745f0baa5ba457a5a0c85a9f549893f Mon Sep 17 00:00:00 2001 From: Ed Tanous Date: Wed, 20 Mar 2024 12:27:06 -0700 Subject: Enable bugprone clang check bugprone-multi-level-implicit-pointer-conversion is something that we pass currently, with one exception in the deprecated rest API. Ignore the one exception, as it's not clear how to fix it, and enable the check. Tested: Clang tidy passes. Change-Id: Idc10e0bb7b876e1c70afa28f9c27cc7bef1db0d7 Signed-off-by: Ed Tanous --- include/openbmc_dbus_rest.hpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'include') diff --git a/include/openbmc_dbus_rest.hpp b/include/openbmc_dbus_rest.hpp index e801a3291c..dd1dac37d9 100644 --- a/include/openbmc_dbus_rest.hpp +++ b/include/openbmc_dbus_rest.hpp @@ -951,7 +951,10 @@ int readMessageItem(const std::string& typeCode, sdbusplus::message_t& m, nlohmann::json& data) { T value; - + // When T == char*, this warning fires. Unclear how to resolve + // Given that sd-bus takes a void pointer to a char*, and that's + // Not something we can fix. + // NOLINTNEXTLINE(bugprone-multi-level-implicit-pointer-conversion) int r = sd_bus_message_read_basic(m.get(), typeCode.front(), &value); if (r < 0) { -- cgit v1.2.3